🔍 Static Analysis Report - January 31, 2026 #12933
Replies: 2 comments 1 reply
-
|
/plan only item 2, cache dir |
Beta Was this translation helpful? Give feedback.
-
Plan Created ✅I've broken down Item 2 (Cache Dir Obfuscation) from the static analysis report into 4 actionable sub-issues: Implementation Plan
Expected Impact
All sub-issues have been created and are ready for assignment to Copilot agents. They will be automatically grouped under a parent tracking issue. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Analysis Summary
Comprehensive security and code quality scan of 147 agentic workflows using three static analysis tools: zizmor (security), poutine (supply chain), and actionlint (linting with shellcheck).
Findings by Tool
Top Priority Issues
1. Default Permissions on Risky Events⚠️ HIGH PRIORITY
Affected Workflows: ai-moderator, archie, brave, cloclo, grumpy-reviewer, mergefest, pdf-summary, plan, pr-nitpick-reviewer, q, scout, security-review, tidy, unbloat-docs
Why This Matters: These workflows trigger on risky events like
issue_comment(which external contributors can trigger) but don't explicitly restrict permissions. They default to write access for repository contents, issues, and pull requests. This violates the principle of least privilege.Risk Scenario: An attacker could:
Recommended Fix: Add explicit minimal permissions to each workflow:
2. Obfuscated GitHub Actions Usage
Pattern Detected: Static values wrapped in unnecessary expression syntax:
GH_AW_CACHE_DESCRIPTION: ${{ '' }}(empty string)GH_AW_CACHE_DIR: ${{ '/tmp/gh-aw/cache-memory/' }}(static path)Why This Matters: While not a direct security vulnerability, obfuscation:
Recommended Fix: Remove unnecessary expression wrappers:
3. ShellCheck Style Issues
Most Common:
Priority: LOW - These are style improvements with no security impact.
Detailed Findings by Tool
Zizmor Security Findings
default_permissions_on_risky_eventsobfuscationunpinnable_actionunverified_script_execView Obfuscation-Affected Workflows (63 total)
Poutine Supply Chain Findings
No issues detected ✅
The scan found no supply chain security issues in the workflows.
Actionlint Linting Issues
Fix Recommendations & Implementation Guide
Priority 1: Fix Default Permissions (HIGH)
Timeline: Immediate (Week 1)
Action Required: Add explicit permissions to 14 workflows that trigger on risky events.
Fix Template:
Workflows to Fix:
.github/workflows/ai-moderator.md.github/workflows/archie.md.github/workflows/brave.md.github/workflows/cloclo.md.github/workflows/grumpy-reviewer.md.github/workflows/mergefest.md.github/workflows/pdf-summary.md.github/workflows/plan.md.github/workflows/pr-nitpick-reviewer.md.github/workflows/q.md.github/workflows/scout.md.github/workflows/security-review.md.github/workflows/tidy.md.github/workflows/unbloat-docs.mdTesting: After applying the fix:
Priority 2: Fix Obfuscation (MEDIUM)
Timeline: Short-term (Week 2-3)
Action Required: Update the workflow compiler to avoid wrapping static values in expression syntax.
Where to Fix: In the compiler code that generates
env:blocks in.lock.ymlfiles.Logic:
${{ }}wrapperExample Compiler Change:
Priority 3: ShellCheck Issues (LOW)
Timeline: Long-term (Optional)
Action Required: Address in compiler if making other changes.
Most common issue (SC2129) is purely stylistic. Consider fixing if:
Not recommended to prioritize over security fixes or feature work.
Historical Trends
First Scan: This is the baseline scan for the repository.
Future Comparisons: Subsequent scans will track:
Long-term Recommendations
1. Integrate Static Analysis into CI/CD
Add these tools to the workflow compilation pipeline:
2. Establish Security Guidelines
Create workflow security guidelines:
3. Periodic Security Reviews
Schedule regular security scans:
4. Improve Compiler Security
Enhance the workflow compiler:
Scan Metadata
Scan Date: 2026-01-31
Repository: githubnext/gh-aw
Branch: main
Workflow Run: §21545944809
Tools Used:
Scan Coverage:
Next Steps
Resources
Fix Templates (stored in cache memory):
/tmp/gh-aw/cache-memory/fix-templates/zizmor-default-permissions.md- Detailed guide for fixing permission issues/tmp/gh-aw/cache-memory/fix-templates/zizmor-obfuscation.md- Guide for removing obfuscation/tmp/gh-aw/cache-memory/fix-templates/shellcheck-SC2129.md- Shellcheck style improvementsScan Data:
/tmp/gh-aw/cache-memory/security-scans/2026-01-31.json/tmp/gh-aw/cache-memory/vulnerabilities/by-tool.json/tmp/gh-aw/cache-memory/security-scans/index.jsonDocumentation:
Beta Was this translation helpful? Give feedback.
All reactions