Skip to content

Commit b90b51a

Browse files
Copilotpelikhan
andcommitted
Fix resolveTarget to handle issue_number field for target="*"
When target="*", the resolveTarget function now checks for item.issue_number in addition to item.item_number and item.pull_request_number. This fixes assign_to_user failing when the agent output uses the standard issue_number field. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
1 parent c28b405 commit b90b51a

10 files changed

+61
-41
lines changed

.github/workflows/dev.lock.yml

Lines changed: 6 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/issue-classifier.lock.yml

Lines changed: 6 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/issue-triage-agent.lock.yml

Lines changed: 6 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/poem-bot.lock.yml

Lines changed: 6 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/smoke-claude.lock.yml

Lines changed: 6 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/smoke-codex.lock.yml

Lines changed: 6 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/smoke-copilot-no-firewall.lock.yml

Lines changed: 6 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/smoke-copilot-playwright.lock.yml

Lines changed: 6 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/smoke-copilot.lock.yml

Lines changed: 6 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/workflow/js/safe_output_helpers.cjs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,23 +93,25 @@ function resolveTarget(params) {
9393
let contextType;
9494

9595
if (target === "*") {
96-
// Use item_number or pull_request_number from item
97-
const numberField = supportsPR ? item.item_number || item.pull_request_number : item.pull_request_number;
96+
// Use item_number, issue_number, or pull_request_number from item
97+
const numberField = supportsPR
98+
? item.item_number || item.issue_number || item.pull_request_number
99+
: item.pull_request_number;
98100

99101
if (numberField) {
100102
itemNumber = typeof numberField === "number" ? numberField : parseInt(String(numberField), 10);
101103
if (isNaN(itemNumber) || itemNumber <= 0) {
102104
return {
103105
success: false,
104-
error: `Invalid ${supportsPR ? "item_number/pull_request_number" : "pull_request_number"} specified: ${numberField}`,
106+
error: `Invalid ${supportsPR ? "item_number/issue_number/pull_request_number" : "pull_request_number"} specified: ${numberField}`,
105107
shouldFail: true,
106108
};
107109
}
108-
contextType = supportsPR && item.item_number ? "issue" : "pull request";
110+
contextType = supportsPR && (item.item_number || item.issue_number) ? "issue" : "pull request";
109111
} else {
110112
return {
111113
success: false,
112-
error: `Target is "*" but no ${supportsPR ? "item_number" : "pull_request_number"} specified in ${itemType} item`,
114+
error: `Target is "*" but no ${supportsPR ? "item_number/issue_number" : "pull_request_number"} specified in ${itemType} item`,
113115
shouldFail: true,
114116
};
115117
}

0 commit comments

Comments
 (0)