Skip to content

Commit e55b0dc

Browse files
authored
Fix ghorg config env (gabrie30#188)
1 parent 0cee3cc commit e55b0dc

File tree

4 files changed

+16
-9
lines changed

4 files changed

+16
-9
lines changed

CHANGELOG.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,14 @@
22
All notable changes to this project will be documented in this file.
33

44
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
5-
5+
## [1.7.10] - unreleased
6+
### Added
7+
### Changed
8+
### Deprecated
9+
### Removed
10+
### Fixed
11+
Configuration env var; thanks @Rabattkarte
12+
### Security
613

714
## [1.7.9] - 2/27/22
815
### Added

cmd/clone.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -709,7 +709,7 @@ func PrintConfigs() {
709709
colorlog.PrintInfo("* Dry Run : " + "true")
710710
}
711711

712-
colorlog.PrintInfo("* Config Used : " + os.Getenv("GHORG_CONF"))
712+
colorlog.PrintInfo("* Config Used : " + os.Getenv("GHORG_CONFIG"))
713713

714714
colorlog.PrintInfo("*************************************")
715715
fmt.Println("")

cmd/root.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,21 +128,21 @@ func getOrSetDefaults(envVar string) {
128128
func InitConfig() {
129129
if config != "" {
130130
viper.SetConfigFile(config)
131-
os.Setenv("GHORG_CONF", config)
131+
os.Setenv("GHORG_CONFIG", config)
132132
} else {
133133
config = configs.DefaultConfFile()
134134
viper.SetConfigType("yaml")
135135
viper.AddConfigPath(configs.GhorgDir())
136136
viper.SetConfigName("conf")
137-
os.Setenv("GHORG_CONF", configs.DefaultConfFile())
137+
os.Setenv("GHORG_CONFIG", configs.DefaultConfFile())
138138

139139
}
140140

141141
if err := viper.ReadInConfig(); err != nil {
142142
if _, ok := err.(viper.ConfigFileNotFoundError); ok {
143-
os.Setenv("GHORG_CONF", "none")
143+
os.Setenv("GHORG_CONFIG", "none")
144144
} else {
145-
colorlog.PrintError(fmt.Sprintf("Something unexpected happened reading configuration file: %s, err: %s", os.Getenv("GHORG_CONF"), err))
145+
colorlog.PrintError(fmt.Sprintf("Something unexpected happened reading configuration file: %s, err: %s", os.Getenv("GHORG_CONFIG"), err))
146146
os.Exit(1)
147147
}
148148
}
@@ -184,7 +184,7 @@ func InitConfig() {
184184
if os.Getenv("GHORG_DEBUG") != "" {
185185
viper.Debug()
186186
fmt.Println("Viper config file used:", viper.ConfigFileUsed())
187-
fmt.Printf("GHORG_CONF SET TO: %s\n", os.Getenv("GHORG_CONF"))
187+
fmt.Printf("GHORG_CONFIG SET TO: %s\n", os.Getenv("GHORG_CONFIG"))
188188
}
189189

190190
}
@@ -193,7 +193,7 @@ func init() {
193193
cobra.OnInitialize(InitConfig)
194194

195195
rootCmd.PersistentFlags().StringVar(&color, "color", "", "GHORG_COLOR - toggles colorful output, enabled/disabled (default: disabled)")
196-
rootCmd.PersistentFlags().StringVar(&config, "config", "", "manually set the path to your config file")
196+
rootCmd.PersistentFlags().StringVar(&config, "config", "", "GHORG_CONFIG - manually set the path to your config file")
197197

198198
viper.SetDefault("config", configs.DefaultConfFile())
199199

cmd/version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@ var versionCmd = &cobra.Command{
1111
Short: "Print the version number of Ghorg",
1212
Long: `All software has versions. This is Ghorg's`,
1313
Run: func(cmd *cobra.Command, args []string) {
14-
fmt.Println("v1.7.9")
14+
fmt.Println("v1.7.10")
1515
},
1616
}

0 commit comments

Comments
 (0)