Fix ghe.com compatibility #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrenn
approved these changes
Apr 11, 2025
|
Will get this released next week alongside a few other changes 👍 |
|
It appears that the security fix that was added on top of this implementation broke it. I've created an issue: #502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #457
Fixes the extension compatibility with Github Enterprise Cloud instances on
<company>.ghe.com.There are two issues I found that needed to be fixed. One was the generation of the API URI, which incorrectly prepended
api.to the protocol rather than the hostname. Second, when comparing the push URL of a remote with the host of the GHE API host it wouldn't match since the remote does not use the API subdomain.