Repository navigation
Commit c73121b
committed
fix(workflows): unwrap groups in the remediation parser too
Addressing review feedback. The evaluator now unwraps a parenthesised
group, but _unresolvable_term did not, so a grouped operand reached the
path check as literal text. A condition the evaluator resolves was
therefore reported unresolvable and format_condition_remediation
withheld the wrap correction from it:
inputs.a or inputs.b -> Wrap the expression: ...
(inputs.a or inputs.b) and inputs.c -> No correction is offered
because '(inputs.a or inputs.b)'
is not a name ...
Mirror the unwrap branch, and cover grouped bare conditions both ways:
a valid group keeps the correction, and an unresolvable name inside a
group still refuses it.1 parent d376a22 commit c73121b
2 files changed
Lines changed: 37 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1179 | 1179 | | |
1180 | 1180 | | |
1181 | 1181 | | |
| 1182 | + | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
| 1186 | + | |
| 1187 | + | |
| 1188 | + | |
1182 | 1189 | | |
1183 | 1190 | | |
1184 | 1191 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
804 | 804 | | |
805 | 805 | | |
806 | 806 | | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
807 | 837 | | |
808 | 838 | | |
809 | 839 | | |
| |||
0 commit comments