fix(scripts): honor SPECIFY_NO_PERSIST in create-new-feature's direct feature.json write

The three create-new-feature variants write .specify/feature.json directly
rather than through get_feature_paths(), so they ignored SPECIFY_NO_PERSIST
entirely, leaving the "stops every core script from writing feature.json"
guarantee in docs/reference/core.md broader than the implementation.

Author: chelsealong

scripts/bash/create-new-feature.sh

@@ -366,8 +366,11 @@ if [ "$DRY_RUN" != true ]; then
         fi
     fi
 
-    # Persist to .specify/feature.json so downstream commands can find the feature
-    _persist_feature_json "$REPO_ROOT" "$FEATURE_DIR"
+    # Persist to .specify/feature.json so downstream commands can find the
+    # feature, unless the orchestrator opted out via SPECIFY_NO_PERSIST (#4129).
+    if [[ "${SPECIFY_NO_PERSIST:-}" != "1" && "${SPECIFY_NO_PERSIST:-}" != "true" ]]; then
+        _persist_feature_json "$REPO_ROOT" "$FEATURE_DIR"
+    fi
 
     # Inform the user how to set feature state in their own shell
     printf '# To persist: export SPECIFY_FEATURE=%s\n' "$(shell_quote "$BRANCH_NAME")" >&2

scripts/powershell/create-new-feature.ps1

@@ -283,8 +283,11 @@ if (-not $DryRun) {
         }
     }
 
-    # Persist to .specify/feature.json so downstream commands can find the feature
-    Save-FeatureJson -RepoRoot $repoRoot -FeatureDirectory $featureDir
+    # Persist to .specify/feature.json so downstream commands can find the
+    # feature, unless the orchestrator opted out via SPECIFY_NO_PERSIST (#4129).
+    if ($env:SPECIFY_NO_PERSIST -ne '1' -and $env:SPECIFY_NO_PERSIST -ne 'true') {
+        Save-FeatureJson -RepoRoot $repoRoot -FeatureDirectory $featureDir
+    }
 
     # Set environment variables for the current session
     $env:SPECIFY_FEATURE = $branchName

scripts/python/create_new_feature.py

@@ -5,6 +5,7 @@
 
 import datetime
 import json
+import os
 import re
 import shlex
 import sys
@@ -406,8 +407,10 @@ def main(argv: list[str] | None = None) -> int:
                 )
                 spec_file.touch()
 
-        # Persist to .specify/feature.json so downstream commands can find the feature.
-        persist_feature_json(repo_root, f"specs/{branch_name}")
+        # Persist to .specify/feature.json so downstream commands can find the
+        # feature, unless the orchestrator opted out via SPECIFY_NO_PERSIST (#4129).
+        if os.environ.get("SPECIFY_NO_PERSIST", "") not in ("1", "true"):
+            persist_feature_json(repo_root, f"specs/{branch_name}")
 
         # Inform the user how to set feature state in their own shell.
         feature_assignment, directory_assignment = _persistence_assignments(

tests/test_specify_no_persist.py

@@ -112,3 +112,48 @@ def test_py_specify_no_persist_suppresses_write(repo: Path) -> None:
     result = run(py_cmd(repo, SCRIPT, "--json"), repo, env)
     assert result.returncode == 0, result.stderr
     assert _feature_json(repo) is None
+
+
+# create-new-feature writes .specify/feature.json directly (not via
+# get_feature_paths()), so it must honor SPECIFY_NO_PERSIST separately.
+
+CREATE_SCRIPT = "create-new-feature"
+SPEC_TEMPLATE_BODY = "# Spec Template\n\nBody.\n"
+
+
+def _create_feature_repo(tmp_path: Path, name: str = "proj") -> Path:
+    repo = make_repo(tmp_path, name)
+    install_scripts(repo, CREATE_SCRIPT)
+    templates = repo / ".specify" / "templates"
+    templates.mkdir(parents=True, exist_ok=True)
+    (templates / "spec-template.md").write_text(SPEC_TEMPLATE_BODY, encoding="utf-8")
+    return repo
+
+
+@requires_bash
+def test_bash_create_new_feature_no_persist_suppresses_write(tmp_path: Path) -> None:
+    repo = _create_feature_repo(tmp_path)
+    env = clean_env()
+    env["SPECIFY_NO_PERSIST"] = "1"
+    result = run(bash_cmd(repo, CREATE_SCRIPT, "--json", "x"), repo, env)
+    assert result.returncode == 0, result.stderr
+    assert _feature_json(repo) is None
+
+
+@pytest.mark.skipif(not HAS_POWERSHELL, reason="no PowerShell available")
+def test_ps_create_new_feature_no_persist_suppresses_write(tmp_path: Path) -> None:
+    repo = _create_feature_repo(tmp_path)
+    env = clean_env()
+    env["SPECIFY_NO_PERSIST"] = "true"
+    result = run(ps_cmd(repo, CREATE_SCRIPT, "-Json", "x"), repo, env)
+    assert result.returncode == 0, result.stderr
+    assert _feature_json(repo) is None
+
+
+def test_py_create_new_feature_no_persist_suppresses_write(tmp_path: Path) -> None:
+    repo = _create_feature_repo(tmp_path)
+    env = clean_env()
+    env["SPECIFY_NO_PERSIST"] = "1"
+    result = run(py_cmd(repo, CREATE_SCRIPT, "--json", "x"), repo, env)
+    assert result.returncode == 0, result.stderr
+    assert _feature_json(repo) is None