fix: give each info entry its provenance as source; empty descriptions as ""

Each command, template and script entry's source is now the layer and the
pack that provide it, as in #4213: {"layer": "preset", "presetId": ...}
or {"layer": "extension", "extensionId": ...}. The top-level source
keeps where the pack was installed from, as in list --json.

A preset contribution with `description:` and no value came out as null:
the preset manifest checks only type, name and file per template. Anything
but a string is now "", with a test. Both reference pages are updated.

Assisted-by: Claude Code (model: Claude Opus 5.5, autonomous)

Author: nefayran

docs/reference/extensions.md

@@ -139,7 +139,9 @@ unique display name, ignoring case. The object has the same `id`, `name`,
 the matching `specify extension list --json` item. In place of the `provides`
 counts it has `commands`, `templates`, `scripts`, and `hooks` arrays. Command,
 template, and script entries have `name`, `description` (`""` when absent),
-`source` (the extension's `source`), and `sourcePath` (the manifest `file`,
+`source` (`{"layer": "extension", "extensionId": "<id>"}`, the extension that
+provides it; the top-level `source` is where it was installed from), and
+`sourcePath` (the manifest `file`,
 relative to the extension directory); script entries also have `runtimes` when
 the manifest declares them. Extension entries carry no `strategy`, because
 extension-provided files always replace. Each hook entry has `trigger` (the

docs/reference/presets.md

@@ -135,7 +135,9 @@ JSON object to stdout. The object has the same `id`, `name`, `description`,
 `specify preset list --json` item. In place of the `provides` counts it has
 `commands`, `templates`, and `scripts` arrays, one entry per manifest
 contribution in declaration order. Each entry has `name`, `description` (`""`
-when absent), `source` (the preset's `source`), `sourcePath` (the manifest
+when absent or empty), `source` (`{"layer": "preset", "presetId": "<id>"}`, the
+preset that provides it; the top-level `source` is where it was installed
+from), `sourcePath` (the manifest
 `file`, relative to the preset directory), and `strategy` (`replace`,
 `prepend`, `append`, or `wrap`; `replace` when the manifest omits it). `--json`
 cannot be combined with `--versions` (usage error, exit 2). A preset that is

src/specify_cli/_installed_info_json.py

@@ -37,10 +37,17 @@ def _find_installed(
 
 
 def _contribution(entry: dict[str, Any], source: dict[str, str]) -> dict[str, Any]:
-    """Return one command, template or script entry of an installed pack."""
+    """Return one command, template or script entry of an installed pack.
+
+    ``source`` is the entry's provenance, the layer and the pack that provide
+    it (#4213); where the pack was installed from is the top-level ``source``.
+    """
+    description = entry.get("description")
     return {
         "name": entry["name"],
-        "description": entry.get("description", ""),
+        # ``description:`` with no value reads as None, and the preset manifest
+        # does not check contribution descriptions
+        "description": description if isinstance(description, str) else "",
         "source": dict(source),
         "sourcePath": entry["file"],
     }
@@ -56,8 +63,9 @@ def preset_info_item(records: list[dict[str, Any]], manager: Any, key: str) -> d
     item = installed_list_item(record, include_hooks=False)
     del item["provides"]
     groups: dict[str, list[dict[str, Any]]] = {"commands": [], "templates": [], "scripts": []}
+    provenance = {"layer": "preset", "presetId": record["id"]}
     for template in manifest.templates:
-        entry = _contribution(template, item["source"])
+        entry = _contribution(template, provenance)
         entry["strategy"] = template.get("strategy", "replace")
         groups[f"{template['type']}s"].append(entry)
     return {**item, **groups}
@@ -74,9 +82,10 @@ def extension_info_item(records: list[dict[str, Any]], manager: Any, key: str) -
 
     item = installed_list_item(record, include_hooks=True)
     del item["provides"]
+    provenance = {"layer": "extension", "extensionId": record["id"]}
     scripts = []
     for script in manifest.scripts:
-        entry = _contribution(script, item["source"])
+        entry = _contribution(script, provenance)
         if "runtimes" in script:
             entry["runtimes"] = list(script["runtimes"])
         scripts.append(entry)
@@ -103,8 +112,8 @@ def extension_info_item(records: list[dict[str, Any]], manager: Any, key: str) -
 
     return {
         **item,
-        "commands": [_contribution(command, item["source"]) for command in manifest.commands],
-        "templates": [_contribution(template, item["source"]) for template in manifest.templates],
+        "commands": [_contribution(command, provenance) for command in manifest.commands],
+        "templates": [_contribution(template, provenance) for template in manifest.templates],
         "scripts": scripts,
         "hooks": hooks,
     }

tests/test_installed_info_json.py

@@ -15,6 +15,9 @@
 runner = CliRunner()
 
 SOURCE = {"kind": "catalog", "catalog": "speckit-official"}
+# provenance of each contribution, as in #4213; SOURCE is where the pack was installed from
+PRESET_SOURCE = {"layer": "preset", "presetId": "info-preset"}
+EXTENSION_SOURCE = {"layer": "extension", "extensionId": "info-ext"}
 
 
 def _project(tmp_path):
@@ -126,7 +129,7 @@ def test_preset_info_json_expands_the_list_item(tmp_path, monkeypatch):
         {
             "name": "speckit.plan",
             "description": "Wrapped plan",
-            "source": SOURCE,
+            "source": PRESET_SOURCE,
             "sourcePath": "commands/plan.md",
             "strategy": "wrap",
         }
@@ -135,7 +138,7 @@ def test_preset_info_json_expands_the_list_item(tmp_path, monkeypatch):
         {
             "name": "spec-template",
             "description": "",
-            "source": SOURCE,
+            "source": PRESET_SOURCE,
             "sourcePath": "templates/spec.md",
             "strategy": "replace",
         }
@@ -144,14 +147,28 @@ def test_preset_info_json_expands_the_list_item(tmp_path, monkeypatch):
         {
             "name": "setup-plan",
             "description": "",
-            "source": SOURCE,
+            "source": PRESET_SOURCE,
             "sourcePath": "scripts/setup-plan.sh",
             "strategy": "wrap",
         }
     ]
 
 
 
+def test_preset_info_json_gives_an_empty_description_as_a_string(tmp_path, monkeypatch):
+    # ``description:`` with no value reads as None; the preset manifest accepts it
+    project = _project(tmp_path)
+    _preset(project)
+    manifest = project / ".specify" / "presets" / "info-preset" / "preset.yml"
+    text = manifest.read_text(encoding="utf-8")
+    manifest.write_text(text.replace("      description: Wrapped plan\n", "      description:\n"), encoding="utf-8")
+    monkeypatch.chdir(project)
+
+    info = _json_result(runner.invoke(app, ["preset", "info", "info-preset", "--json"]))
+
+    assert info["commands"][0]["description"] == ""
+
+
 def test_a_direct_call_to_preset_info_keeps_the_human_readable_view(tmp_path, monkeypatch, capsys):
     from specify_cli.presets.command_info import preset_info
 
@@ -182,22 +199,22 @@ def test_extension_info_json_expands_the_list_item(tmp_path, monkeypatch):
         {
             "name": "speckit.info-ext.check",
             "description": "Run the check",
-            "source": SOURCE,
+            "source": EXTENSION_SOURCE,
             "sourcePath": "commands/check.md",
         }
     ]
     assert info["templates"] == [
-        {"name": "report", "description": "", "source": SOURCE, "sourcePath": "templates/report.md"}
+        {"name": "report", "description": "", "source": EXTENSION_SOURCE, "sourcePath": "templates/report.md"}
     ]
     assert info["scripts"] == [
         {
             "name": "collect",
             "description": "",
-            "source": SOURCE,
+            "source": EXTENSION_SOURCE,
             "sourcePath": "scripts/collect.sh",
             "runtimes": ["bash", "python"],
         },
-        {"name": "notify", "description": "", "source": SOURCE, "sourcePath": "scripts/notify.sh"},
+        {"name": "notify", "description": "", "source": EXTENSION_SOURCE, "sourcePath": "scripts/notify.sh"},
     ]