Update tests to allow chains in any order. Fixes #68. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarron
commented
Jul 30, 2020
| @@ -37,8 +46,8 @@ func TestSignIncludeCertsAIA(t *testing.T) { | |||
| require.NoError(t, err) | |||
|
|
|||
| require.Equal(t, 2, len(certs)) | |||
There was a problem hiding this comment.
Note that we already check the chain size, so we'll still be testing that the chains are "equal" to what is expected.
fletchto99
approved these changes
Jul 30, 2020
The chain in question is defined in RFC5652 as a CertificateSet, which is a `SET OF` certs: - https://tools.ietf.org/html/rfc5652#section-5.1 - https://tools.ietf.org/html/rfc5652#section-10.2.3 Go 1.15 introduced a change that sorts such sets: https://go.googlesource.com/go/+/f0cea848679b8f8cdc5f76e1b1e36ebb924a68f8 Our tests were implicitly relying on the sets to stay sorted, but the right thing to do at this point is update our tests.
lgarron
force-pushed
the
cert-set-test-fix
branch
from
a9d7043 to
d7c50b9
Compare
|
🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chain in question is defined in RFC5652 as a CertificateSet, which is a
SET OFcerts:Go 1.15 introduced a change that sorts such sets: https://go.googlesource.com/go/+/f0cea848679b8f8cdc5f76e1b1e36ebb924a68f8
Our tests were implicitly relying on the sets to stay in the order we order we create them (leaf then intermediate then root, or a truncated subset of those), but the right thing to do at this point is update our tests.