Skip to content

Commit f8d7345

Browse files
authored
Merge pull request #704 from github/hubot/jekyll-v3-9-0
Bump jekyll to v3.9.0, kramdown to v2.3.0
2 parents 3716171 + 044a9e1 commit f8d7345

File tree

5 files changed

+24
-3
lines changed

5 files changed

+24
-3
lines changed

lib/github-pages/dependencies.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,12 @@ module GitHubPages
77
class Dependencies
88
VERSIONS = {
99
# Jekyll
10-
"jekyll" => "3.8.7",
10+
"jekyll" => "3.9.0",
1111
"jekyll-sass-converter" => "1.5.2",
1212

1313
# Converters
14-
"kramdown" => "1.17.0",
14+
"kramdown" => "2.3.0",
15+
"kramdown-parser-gfm" => "1.1.0",
1516
"jekyll-commonmark-ghpages" => "0.1.6",
1617

1718
# Misc

spec/fixtures/kramdown-parser-gfm.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
---
3+
4+
# Test
5+
6+
~~Nope~~Yes

spec/fixtures/kramdown.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,7 @@
22
---
33

44
# Test
5+
6+
### Math
7+
8+
$$a^2 + b^2 = c^2$$

spec/github-pages/dependencies_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
describe(GitHubPages::Dependencies) do
66
CORE_DEPENDENCIES = %w(
7-
jekyll kramdown liquid rouge jekyll-sass-converter
7+
jekyll kramdown kramdown-parser-gfm liquid rouge jekyll-sass-converter
88
github-pages-health-check
99
).freeze
1010
PLUGINS = described_class::VERSIONS.keys - CORE_DEPENDENCIES

spec/github-pages/integration_spec.rb

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,16 @@ def rm_destination
9393
it "converts markdown to HTML" do
9494
expect(contents).to match('<h1 id="test">Test</h1>')
9595
end
96+
97+
it "converts math to mathjax" do
98+
expect(contents).to include('\[a^2 + b^2 = c^2\]')
99+
end
100+
end
101+
102+
context "kramdown-parser-gfm" do
103+
it "converts GFM to HTML" do
104+
expect(contents).to match("<del>Nope</del>Yes")
105+
end
96106
end
97107

98108
context "liquid" do

0 commit comments

Comments
 (0)