throw errors rather than resolving them #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
approved these changes
Dec 1, 2022
|
Ah, it looks like I misunderstood what include-fragment-element/src/index.ts Line 171 in c405e3a Thanks for the fix! |
lgarron
reviewed
Dec 2, 2022
Comment on lines
199
to
201
| if (data instanceof Error) { | ||
| return data | ||
| throw data | ||
| } |
There was a problem hiding this comment.
This might now be unreachable and safe to remove?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lgarron a slight change in the API to be more idiomatic (and also backwards compatible).
Instead of returning Error objects, we throw them so the Promise rejects.