Skip to content

Fix GHES hostname pattern check #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jtquip88
Copy link

Currently, any hostname ending with "github.com" (such as "slack-github.com") is incorrectly identified as the public GitHub host github.com.

This PR changes the public github hostname check from a suffix match to an exact match:

Before: strings.HasSuffix(u.Hostname(), "github.com")
After: u.Hostname() == "github.com"

This ensures that GHES hostnames like "slack-github.com" are correctly identified as GitHub Enterprise Server instances rather than being treated as the public GitHub.com.
Alternative approaches:

  1. I am not sure if public github hosts can have subdomains, but if needed a regex can be used to match host name patterns.
  2. Add extra optional parameter like IS_GHES to explicitly indicate that this is a GHES instance.

Fixes #662

@jtquip88 jtquip88 requested a review from a team as a code owner July 12, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom GHES host names are not supported
1 participant