-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: tool prefix name #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hungran
wants to merge
4
commits into
github:main
Choose a base branch
from
hungran:hungran/tool-prefix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+25
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for an optional tool-prefix
flag to disambiguate tool names by prepending a user-specified string.
- Introduce a
tool-prefix
CLI flag and bind it via Viper. - Extend
MCPServerConfig
andStdioServerConfig
to includeToolPrefix
and propagate it into server registration. - Update
Toolset.RegisterTools
andToolsetGroup.RegisterAll
to accept a prefix and register tools with prefixed names.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
pkg/toolsets/toolsets.go | Added createToolWithPrefixedName and updated RegisterTools to apply the prefix when registering tools. |
internal/ghmcp/server.go | Added ToolPrefix to MCPServerConfig /StdioServerConfig and passed it into RegisterAll and dynamic toolset registration. |
cmd/github-mcp-server/main.go | Defined the tool-prefix flag in Cobra, bound it to Viper, and populated the CLI config. |
Comments suppressed due to low confidence (2)
pkg/toolsets/toolsets.go:106
- No unit tests were added to verify the new prefix logic in
RegisterTools
. Adding tests to confirm that tools are registered with the correct prefixed names would help prevent regressions.
func (t *Toolset) RegisterTools(s *server.MCPServer, prefix string) {
pkg/toolsets/toolsets.go:110
- [nitpick] The parameter name
tool
shadows the outer loop variable and may be confusing. Consider renaming it (e.g., tosrvTool
) to make the code clearer.
registerToolWithPrefix := func(tool server.ServerTool) {
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>
c65be5c
to
ca62561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #333
introduce arg flag
tool-prefix
so client able to add prefix name of tools, avoid conflict tool name with another mcp server