fix array schemas #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the array schemas for GitHub API operations by defining explicit object schemas for array items in both file uploads and pull request review comments.
- In pkg/github/repositories.go, the file objects now have a schema with defined properties for path and content.
- In pkg/github/pullrequests.go, a similar schema has been added for comment objects with properties for path, position, and body.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/repositories.go | Added schema for file objects with properties for path/content |
| pkg/github/pullrequests.go | Added schema for comment objects with properties for path, position, and body |
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
SamMorrowDrums
approved these changes
Mar 24, 2025
Collaborator
SamMorrowDrums
left a comment
SamMorrowDrums
left a comment
There was a problem hiding this comment.
I hope this is eventually cleaned up into part of WithArray more naturally, but this is better than failing.
manian0430
pushed a commit
to ChrisLally/github-mcp-server
that referenced
this pull request
Apr 12, 2025
DaleSeo
pushed a commit
to DaleSeo/github-mcp-server
that referenced
this pull request
Oct 24, 2025
* feat: adding wizard to simplify server config creation Signed-off-by: Ivan Pedrazas <ivan.pedrazas@docker.com> * Update CONTRIBUTING.md Co-authored-by: Cody Rigney <cody.rigney@docker.com> --------- Signed-off-by: Ivan Pedrazas <ivan.pedrazas@docker.com> Co-authored-by: Cody Rigney <cody.rigney@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds schemas for the the array items. Without this, we were creating schemas where arrays didn't have their items specified. This caused issues in 4o.