Skip to content

Expose Group.group? for testing if entry is a group #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2014
Merged

Conversation

mtodd
Copy link
Member

@mtodd mtodd commented Dec 3, 2014

Minimal change to expose GitHub::Ldap::Group.group?(entry) to check if the objectClass matches any known group types (group, groupOfNames, groupOfUniqueNames).

cc @jch

mtodd added a commit that referenced this pull request Dec 3, 2014
Expose Group.group? for testing if entry is a group
@mtodd mtodd merged commit 3762988 into master Dec 3, 2014
@mtodd mtodd deleted the is-group branch December 3, 2014 00:39
@jch
Copy link
Contributor

jch commented Dec 3, 2014

@mtodd The class method makes sense to me since the method doesn't depend on any instance state. The group? instance method was previously documented as internal, how do you feel about removing the instance method and just calling the class method when we need it? I only see one caller in this file.

@mtodd
Copy link
Member Author

mtodd commented Dec 3, 2014

@jch was tempted to make that change but decided to address that separately. I think you're right, though, it's way more useful like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants