Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binlog compress #1447

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Binlog compress #1447

wants to merge 3 commits into from

Conversation

fulldb
Copy link

@fulldb fulldb commented Sep 5, 2024

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.

Related issue: #884

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md
Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR [briefly explain what it does]

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@fulldb
Copy link
Author

fulldb commented Sep 5, 2024

Related issue:
#884

support enabled this parameter binlog_transaction_compression
support binlog_transaction_compression =on

@fulldb fulldb reopened this Sep 5, 2024
@timvaillancourt
Copy link
Collaborator

timvaillancourt commented Oct 1, 2024

@fulldb thanks for this great contribution! Is it possible to add a unit test that confirms this behaviour?

Preferably this would validate a compressed row event ends up as an event we expect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants