-
Notifications
You must be signed in to change notification settings - Fork 46
Remove noop from handler registry and clarify skip reason logging #12923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
Agent Container Tool Check
Result: 11/12 tools available ❌ FAIL Note: .NET (dotnet) is not available in the agent container. All other essential development tools are present and functional.
|
|
chore: refine default campaign orchestrator rules | Remove noop from handler registry and clarify skip reason logging
|
|
Smoke Test Results PRs: #12925 (chore: refine default campaign orchestrator rules), #12923 (Remove noop from handler registry) ✅ GitHub MCP Status: ✅ PASS cc @mnkiefer
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
Smoke Test Results:
Status: PASS ✅
|
The
noopsafe output type was incorrectly included in the handler registry, causing it to appear inGH_AW_SAFE_OUTPUTS_HANDLER_CONFIGdespite always being processed by a dedicated standalone step. Additionally, skip reason logging conflated project-related types with other standalone types.Changes
Remove noop from handler registry
noopbuilder fromhandlerRegistryinpkg/workflow/compiler_safe_outputs_config.gonotify_comment.go), never by handler managerGH_AW_SAFE_OUTPUTS_HANDLER_CONFIG:Distinguish skip reasons
PROJECT_RELATED_TYPESset insafe_output_handler_manager.cjs"Handled by project handler step"for create_project, update_project, create_project_status_update, copy_project"Handled by standalone step"for noop, assign_to_agent, create_agent_session, upload_assetUpdated tests
TestAutoEnabledHandlers(no longer auto-enabled in handler manager)safe_output_handler_manager.test.cjsOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Changeset
.github/agentics/) from frontmatter/locks and keep the noop safe output out of the handler manager config that workflow lock files ship.