Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add check for existing issues #26

Merged
merged 3 commits into from
Jan 29, 2024
Merged

feat: Add check for existing issues #26

merged 3 commits into from
Jan 29, 2024

Conversation

chrheg
Copy link
Contributor

@chrheg chrheg commented Jan 26, 2024

Pull Request

Add check for existing issues, also change the pull request name matching to match the title value.

Fixes #9

Proposed Changes

  • These changes allow us to run the script with issue mode without bloating the repositories with issues.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@chrheg chrheg requested a review from zkoppert as a code owner January 26, 2024 18:00
evergreen.py Show resolved Hide resolved
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderfully readable code and Thanks for the improvement!!

@zkoppert zkoppert added the enhancement New feature or request label Jan 26, 2024
@zkoppert
Copy link
Member

Looks like isort and black are chasing each other here by not agreeing on the proper sort order. I think we may need to add a .isort.cfg file with these contents:

[tool.isort]
profile = "black"

source: PyCQA/isort#1518 (comment)

@chrheg
Copy link
Contributor Author

chrheg commented Jan 26, 2024

Added the the .isort.cfg file

@chrheg
Copy link
Contributor Author

chrheg commented Jan 27, 2024

Looks like isort and black are chasing each other here by not agreeing on the proper sort order. I think we may need to add a .isort.cfg file with these contents:

[tool.isort]
profile = "black"

source: PyCQA/isort#1518 (comment)

Did some testing looks like it need to be:

[isort]
profile = black

Did some testing on my end as well , and the make lint seems to not agree with all changes that the superlinter wants.

@zkoppert zkoppert merged commit 92d440d into github:main Jan 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for duplicate issues
2 participants