Support ESLint 10: widen peer range and fix eslint-comments in flat recommended config#713
Merged
Merged
Conversation
…ecommended config
There was a problem hiding this comment.
Pull request overview
This PR makes minimal compatibility updates so eslint-plugin-github can be consumed in projects upgrading to ESLint 10, while keeping existing ESLint 8/9 support. It widens the peer dependency range and adjusts the flat “recommended” config’s plugin wiring to work under ESLint 10.
Changes:
- Expand
eslintpeer dependency range to include^10. - Update the lockfile to reflect the new peer dependency range.
- Fix flat
recommendedconfig plugin registration by wrappingeslint-plugin-eslint-commentswith@eslint/compat’sfixupPluginRules.
Show a summary per file
| File | Description |
|---|---|
| package.json | Widens eslint peer dependency range to `^8 |
| package-lock.json | Updates root package peer dependency entry to match the widened ESLint range. |
| lib/configs/flat/recommended.js | Wraps eslint-comments plugin with fixupPluginRules for flat-config compatibility. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Low
manuelpuyol
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimum changes needed to support ESlint 10 in github-ui. As part of https://github.com/github/web-systems/issues/5207.
What changes are proposed: (they were tested as local directories on github-ui locally)
Changed peerDependencies from ^8 || ^9 to ^8 || ^9 || ^10 in:
package.json:62
package-lock.json:49
Wrapped eslint-plugin-eslint-comments with @eslint/compat in:
recommended.js:20