Skip to content

Support ESLint 10: widen peer range and fix eslint-comments in flat recommended config#713

Merged
manuelpuyol merged 1 commit into
mainfrom
alaingoga/eslint10-compact
Jul 7, 2026
Merged

Support ESLint 10: widen peer range and fix eslint-comments in flat recommended config#713
manuelpuyol merged 1 commit into
mainfrom
alaingoga/eslint10-compact

Conversation

@alaingoga

@alaingoga alaingoga commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Minimum changes needed to support ESlint 10 in github-ui. As part of https://github.com/github/web-systems/issues/5207.

What changes are proposed: (they were tested as local directories on github-ui locally)

  1. Expanded supported ESLint peer range
    Changed peerDependencies from ^8 || ^9 to ^8 || ^9 || ^10 in:
    package.json:62
    package-lock.json:49
  2. Fixed flat recommended plugin wiring for compatibility
    Wrapped eslint-plugin-eslint-comments with @eslint/compat in:
    recommended.js:20

Copilot AI review requested due to automatic review settings July 6, 2026 15:59
@alaingoga alaingoga requested a review from a team as a code owner July 6, 2026 15:59
@alaingoga alaingoga requested a review from arelia July 6, 2026 15:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes minimal compatibility updates so eslint-plugin-github can be consumed in projects upgrading to ESLint 10, while keeping existing ESLint 8/9 support. It widens the peer dependency range and adjusts the flat “recommended” config’s plugin wiring to work under ESLint 10.

Changes:

  • Expand eslint peer dependency range to include ^10.
  • Update the lockfile to reflect the new peer dependency range.
  • Fix flat recommended config plugin registration by wrapping eslint-plugin-eslint-comments with @eslint/compat’s fixupPluginRules.
Show a summary per file
File Description
package.json Widens eslint peer dependency range to `^8
package-lock.json Updates root package peer dependency entry to match the widened ESLint range.
lib/configs/flat/recommended.js Wraps eslint-comments plugin with fixupPluginRules for flat-config compatibility.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/3 changed files
  • Comments generated: 0
  • Review effort level: Low

@manuelpuyol manuelpuyol merged commit 3611a16 into main Jul 7, 2026
11 checks passed
@manuelpuyol manuelpuyol deleted the alaingoga/eslint10-compact branch July 7, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants