Add tests

github · Jul 17, 2023 · a7418b2 · a7418b2
1 parent 1aa7815
commit a7418b2
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/lib/utils/get-role.js b/lib/utils/get-role.js
@@ -1,4 +1,4 @@
-const {getProp, getPropValue, getLiteralPropValue} = require('jsx-ast-utils')
+const {getProp, getLiteralPropValue} = require('jsx-ast-utils')
 const {elementRoles} = require('aria-query')
 const {getElementType} = require('./get-element-type')
 const ObjectMap = require('./object-map')
@@ -80,8 +80,8 @@ function getRole(context, node) {
       continue
     }
 
-    const value = getPropValue(propOnNode)
-    if (value || (value === '' && prop === 'alt')) {
+    const value = getLiteralPropValue(propOnNode)
+    if (propOnNode) {
       if (
         prop === 'href' ||
         prop === 'aria-labelledby' ||
@@ -90,7 +90,7 @@ function getRole(context, node) {
         (prop === 'alt' && value !== '')
       ) {
         key.attributes.push({name: prop, constraints: ['set']})
-      } else {
+      } else if (value || (value === '' && prop === 'alt')) {
         key.attributes.push({name: prop, value})
       }
     }

diff --git a/tests/utils/get-role.js b/tests/utils/get-role.js
@@ -46,14 +46,27 @@ describe('getRole', function () {
     expect(getRole({}, node)).to.equal('link')
   })
 
-  it('returns link role for <Foo> with polymorphic prop set to "a" and href', function () {
+  it('returns link role for <Foo> with polymorphic prop set to "a" and conditional href', function () {
     const node = mockJSXOpeningElement('Foo', [
       mockJSXAttribute('as', 'a'),
-      [mockJSXConditionalAttribute('href', 'getUrl', '#', 'https://github.com/')],
+      mockJSXConditionalAttribute('href', 'getUrl', '#', 'https://github.com/'),
     ])
     expect(getRole({}, node)).to.equal('link')
   })
 
+  it('returns link role for <Foo> with polymorphic prop set to "a" and literal href', function () {
+    const node = mockJSXOpeningElement('Foo', [
+      mockJSXAttribute('as', 'a'),
+      mockJSXAttribute('href', 'https://github.com/'),
+    ])
+    expect(getRole({}, node)).to.equal('link')
+  })
+
+  it('returns generic role for <Foo> with polymorphic prop set to "a" and no href', function () {
+    const node = mockJSXOpeningElement('Foo', [mockJSXAttribute('as', 'a')])
+    expect(getRole({}, node)).to.equal('generic')
+  })
+
   it('returns region role for <section> with aria-label', function () {
     const node = mockJSXOpeningElement('section', [mockJSXAttribute('aria-label', 'something')])
     expect(getRole({}, node)).to.equal('region')