Skip to content

Commit 7bbc2a1

Browse files
authored
Merge pull request #94 from github/remove-node-config-and-babel
Remove node config and babel
2 parents e278c1f + 396744b commit 7bbc2a1

File tree

7 files changed

+10
-132
lines changed

7 files changed

+10
-132
lines changed

.eslintrc.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
module.exports = {
2-
parser: 'babel-eslint',
32
parserOptions: {
4-
ecmaVersion: 6
3+
ecmaVersion: 2020
54
},
65
env: {
76
es6: true,

bin/eslint-github-init.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const questions = [
3535
type: 'list',
3636
name: 'env',
3737
message: 'Which environment does this library target?',
38-
choices: ['browser', 'node'],
38+
choices: ['browser'],
3939
default: defaults.env
4040
},
4141
{
@@ -50,9 +50,7 @@ const questions = [
5050
inquirer.prompt(questions).then(answers => {
5151
const eslintrc = {extends: ['plugin:github/es6']}
5252

53-
if (answers.env === 'node') {
54-
eslintrc.extends.push('plugin:github/node')
55-
} else if (answers.project === 'app') {
53+
if (answers.project === 'app') {
5654
eslintrc.extends.push('plugin:github/app')
5755
} else if (answers.env === 'browser') {
5856
eslintrc.extends.push('plugin:github/browser')

docs/configs.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,3 @@ Recommended rules when using Babel to transpile features from ES2015+.
2929
### `plugin:github/app`
3030

3131
Recommended rules when writing a browser application.
32-
33-
### `plugin:github/node`
34-
35-
Recommended rules when writing a node application.

lib/configs/node.js

Lines changed: 0 additions & 11 deletions
This file was deleted.

lib/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ module.exports = {
2121
app: require('./configs/app'),
2222
browser: require('./configs/browser'),
2323
es6: require('./configs/es6'),
24-
node: require('./configs/node'),
2524
recommended: require('./configs/recommended'),
2625
typescript: require('./configs/typescript')
2726
}

package-lock.json

Lines changed: 5 additions & 105 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,9 @@
2828
"url": "https://github.com/github/eslint-plugin-github/issues"
2929
},
3030
"homepage": "https://github.com/github/eslint-plugin-github#readme",
31-
"engines": {
32-
"node": ">=8.11.1"
33-
},
3431
"dependencies": {
3532
"@typescript-eslint/eslint-plugin": ">=2.5.0",
3633
"@typescript-eslint/parser": ">=2.5.0",
37-
"babel-eslint": ">=10.0.3",
3834
"eslint-config-prettier": ">=6.4.0",
3935
"eslint-plugin-eslint-comments": ">=3.0.1",
4036
"eslint-plugin-import": ">=2.18.2",
@@ -44,7 +40,8 @@
4440
"prettier": ">=1.12.0",
4541
"read-pkg-up": ">=6.0.0",
4642
"supports-color": "^7.1.0",
47-
"svg-element-attributes": ">=1.2.1"
43+
"svg-element-attributes": ">=1.2.1",
44+
"to-fast-properties": "^3.0.1"
4845
},
4946
"peerDependencies": {
5047
"eslint": ">=4.19.0"

0 commit comments

Comments
 (0)