Skip to content

Document npm run build step #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2020
Merged

Document npm run build step #984

merged 4 commits into from
Nov 5, 2020

Conversation

sarahs
Copy link
Contributor

@sarahs sarahs commented Nov 2, 2020

See #940 (comment).

This PR documents how to run the npm run build step to create static assets locally.

@welcome
Copy link

welcome bot commented Nov 2, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Thanks for adding this information. 👍

@chiedo chiedo self-requested a review November 2, 2020 14:20
Copy link
Contributor

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thanks @sarahs!

@sarahs sarahs merged commit b846851 into main Nov 5, 2020
@sarahs sarahs deleted the document-npm-run-build branch November 5, 2020 17:20
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants