Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword "name" and "about" issue template frontmatter (#7570) #7938

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Reword "name" and "about" issue template frontmatter (#7570) #7938

merged 3 commits into from
Jul 6, 2021

Conversation

Simran-B
Copy link
Contributor

@Simran-B Simran-B commented Jul 4, 2021

Why:

Closes #7570

What's being changed:

Change name and about keys of the "content" and "engineering" issue templates to clarify the difference between the two.

@Simran-B Simran-B requested a review from a team as a code owner July 4, 2021 21:14
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 4, 2021
@ramyaparimi @Simran-B
Update .github/ISSUE_TEMPLATE/improve-the-site.md
fafaacb 
Co-authored-by: Simran <Simran-B@users.noreply.github.com>
ramyaparimi
ramyaparimi approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening the PR with this fix. I will update the branch and merge this once tests are passed ⚡

@ramyaparimi ramyaparimi added ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 6, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Jul 6, 2021
@ramyaparimi ramyaparimi added the waiting for review Issue/PR is waiting for a writer's review label Jul 6, 2021
@janiceilene janiceilene merged commit c376d7d into github:main Jul 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@Simran-B Simran-B deleted the reword-issue-templates branch July 6, 2021 23:03
@snyk-bot snyk-bot mentioned this pull request Jul 31, 2022
Open
@Alex11ru Alex11ru mentioned this pull request Jul 31, 2022
Open
@nahnicholas nahnicholas mentioned this pull request Jul 31, 2022
Open
@eiygy eiygy mentioned this pull request Jul 31, 2022
Open
This was referenced Jul 31, 2022
Open
Open
Open
@violethaze74 violethaze74 mentioned this pull request Jul 31, 2022
Open
@BryanLaura BryanLaura mentioned this pull request Jul 31, 2022
Open
@brandingfuture brandingfuture mentioned this pull request Jul 31, 2022
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 31, 2022
Open
This was referenced Jul 31, 2022
Open
Open
@iliya2006 iliya2006 mentioned this pull request Aug 1, 2022
Open
@lasoforo lasoforo mentioned this pull request Aug 1, 2022
Open
@Wrath77Firefox Wrath77Firefox mentioned this pull request Aug 1, 2022
Open
@mmoohhkanahmady mmoohhkanahmady mentioned this pull request Aug 1, 2022
Open
@Dsanchez05202210 Dsanchez05202210 mentioned this pull request Aug 1, 2022
Open
@Visva92 Visva92 mentioned this pull request Aug 1, 2022
Open
This was referenced Aug 1, 2022
Open
Open
@eddiephoen123 eddiephoen123 mentioned this pull request Aug 1, 2022
Open
@Ciampi10 Ciampi10 mentioned this pull request Aug 1, 2022
Merged
@ros2-ship ros2-ship mentioned this pull request Aug 1, 2022
Open
@CALISOULB CALISOULB mentioned this pull request Aug 1, 2022
Open
@comunikatormiui comunikatormiui mentioned this pull request Aug 1, 2022
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Aug 1, 2022
Open
@Ethanpinky Ethanpinky mentioned this pull request Aug 1, 2022
Merged
This was referenced Aug 1, 2022
Open
Open
@pratapadi pratapadi mentioned this pull request Aug 1, 2022
Open
@Pakonkiat19961 Pakonkiat19961 mentioned this pull request Aug 1, 2022
Open
@ryan-ally ryan-ally mentioned this pull request Aug 1, 2022
Merged
This was referenced Aug 1, 2022
Open
Closed
Open
@Sailayko Sailayko mentioned this pull request Aug 1, 2022
Open
@Deucemob33 Deucemob33 mentioned this pull request Aug 1, 2022
Open
@jefferycline1 jefferycline1 mentioned this pull request Aug 1, 2022
Open
This was referenced Aug 1, 2022
Closed
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramyaparimi ramyaparimi ramyaparimi approved these changes

Assignees
No one assigned
Labels
ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make difference between content and engineering issues clearer in issue template chooser
4 participants
@Simran-B @ramyaparimi @Adriamo132 @janiceilene