Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slack to github integrations list #542

Merged
merged 4 commits into from
Oct 19, 2020

Conversation

ParkourKarthik
Copy link
Contributor

@ParkourKarthik ParkourKarthik commented Oct 15, 2020

Why:

closes #432

What's being changed:

Included slack to github integration list

Check off the following:

@welcome
Copy link

welcome bot commented Oct 15, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks so much for opening a PR @ParkourKarthik! I'll get this triaged for review 🎉

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 15, 2020
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for picking this issue up. It'll be really helpful for users to have a fuller list of integrations created by GitHub. ✨

I've made a couple of suggestions of small changes to improve clarity.

It's not suggested in the issue but, if you have time, it would be great to add links from the Jira and Slack sections to the marketplace docs - using the same format as for the Editor tools. The information there is quite detailed:

Co-authored-by: Felicity Chapman <felicitymay@github.com>
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Can you let me know if you plan to add the links I suggested too? I don't want to merge the PR if you're planning further work.

@ParkourKarthik
Copy link
Contributor Author

@felicitymay Sure, will work on updating the links as preferred.

@felicitymay
Copy link
Contributor

Sure, will work on updating the links as preferred.

Thanks, that sounds good. 🙇🏻‍♀️
I think this is really worth doing as it will mean that we don't have to update the notes you've added if new functionality is added to the integrations, but people can easily follow up to see the latest information. I'll keep an eye open for further changes to this pull request.

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the links. This topic looks much better with your work 💎 ✨

I'll update your branch from main and merge.

@felicitymay felicitymay merged commit bab5149 into github:main Oct 19, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@felicitymay
Copy link
Contributor

🎉 🚢

I think that you might need to close the issue that you've fixed manually, since this PR wasn't mentioned as a fix for #432. I should have noticed that before and then I could have added a comment to link the PR to the issue before I merged 🤦🏻

(For reference: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue.)

@ParkourKarthik
Copy link
Contributor Author

Sorry that I missed. I can't close the issue as I don't have the option ( probably rights). Tried updating the description here but didn't work 🤷

@felicitymay
Copy link
Contributor

Ah. No problem - I didn't realize. I'll update the issue shortly (in a meeting right now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Slack to list of GitHub-created apps
3 participants