Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a quick tip about PR's base branch #480

Merged
merged 4 commits into from
Oct 19, 2020

Conversation

Ruth-ikegah
Copy link
Contributor

Why:

This issue fixes issue #431 as regards adding a quick tip about a pull request's base branch

What's being changed:

A quick tip with a block quote to Changing the base branch of a pull request

Check off the following:

Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ruth-ikegah Thanks for taking this one on! It was more complex than it looked like initially! I made one suggestion. After you update with the suggestions, we can double check the staging link to make sure it looks good and get it shipped!

…nging-the-base-branch-of-a-pull-request.md

Co-authored-by: Janice <janiceilene@github.com>
@Ruth-ikegah
Copy link
Contributor Author

@Ruth-ikegah Thanks for taking this one on! It was more complex than it looked like initially! I made one suggestion. After you update with the suggestions, we can double check the staging link to make sure it looks good and get it shipped!

Thanks @janiceilene suggestions have been applied

@janiceilene
Copy link
Contributor

Thanks so much @Ruth-ikegah! I'll update the branch and get this merged once tests are green 🍏

@janiceilene janiceilene merged commit 57b2bad into github:main Oct 19, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* fix typo

* other type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants