Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of pusher_type to create_properties and delete_properties webhooks #4570

Merged
merged 4 commits into from
Mar 19, 2021
Merged

Conversation

vivekshotti
Copy link
Contributor

@vivekshotti vivekshotti commented Mar 16, 2021

Why:

**Closes #3192 **

What's being changed:

So apparently The docs for DeleteEvent mention two fields, ref, and ref_type. However, there is a third field that appears in API calls, pusher_type. It seems pusher_type should also appear in the docs.

@skedwards88 later also pointed out that pusher_type is in the payload for DeleteEvent and also for CreateEvent, with values that can be user or a deploy key.

I've added the same in the reusable webhooks of create_properties and delete_properties.
Hope @janiceilene approves it. Open to suggestions / changes. You could view the live deployment here

Check off the following:

@janiceilene
Copy link
Contributor

Thanks so much for opening a PR for this fix @Vivek-Hotti! I'll get this triaged for review ⚡

@janiceilene janiceilene added webhooks Content related to webhooks waiting for review Issue/PR is waiting for a writer's review labels Mar 16, 2021
@imansameri

This comment has been minimized.

@lucascosti lucascosti self-assigned this Mar 19, 2021
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Vivek-Hotti, thanks heaps for this fix!

I've made a slight change to your PR, which makes the new pusher_type table row a reusable which we can use for both the create and delete event docs (rather than manually repeating it in both).

I'll get this merged in when the tests pass! 🎉

@lucascosti lucascosti enabled auto-merge (squash) March 19, 2021 05:05
@lucascosti lucascosti merged commit 84fdf58 into github:main Mar 19, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for review Issue/PR is waiting for a writer's review webhooks Content related to webhooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing field in Event API docs for DeleteEvent
4 participants