Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Dependabot configuration copy edit #4566

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Conversation

olets
Copy link
Contributor

@olets olets commented Mar 16, 2021

Why:

Closes #4564

What's being changed:

Removes a word that appears to be unnecessary, with the result of making a sentence clear.

Check off the following:

@welcome
Copy link

welcome bot commented Mar 16, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@olets olets marked this pull request as ready for review March 16, 2021 15:03
@olets
Copy link
Contributor Author

olets commented Mar 16, 2021

I initially opened this as a draft so that I could check the "I have reviewed in staging" box before claiming the PR was ready for review. Is that why the triage action failed? (I have not investigated.) Lmk, I can open a bug ticket.

@janiceilene
Copy link
Contributor

@olets Thank you so much for opening an issue and a PR with your updates! I think our tests were probably being buggy. Looks like they're all passing now 🍏 I'll get this triaged for review ⚡

@janiceilene janiceilene added the dependabot Content related to Dependabot label Mar 16, 2021
@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Mar 18, 2021
@shati-patel shati-patel self-assigned this Mar 19, 2021
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the confusing text, @olets 😃 Your change looks great, so I'll get this pull request merged shortly!

@shati-patel shati-patel enabled auto-merge (squash) March 19, 2021 13:32
@shati-patel shati-patel added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 19, 2021
@shati-patel shati-patel merged commit 0694021 into github:main Mar 19, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependabot Content related to Dependabot ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot configuration docs confusing sentence
4 participants