Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubuntu-latest instead of 16.04 as an Actions example #445

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Oct 12, 2020

Why:

While this doc is using ubuntu-16.04, this should be latest as this is not specific to 16.04.

What's being changed:

Use ubuntu-latest instead of 16.04 as an example of Context and expression syntax for GitHub Actions.

Check off the following:

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@janiceilene
Copy link
Contributor

Thanks for opening a PR @tnir! I'll triage this for review 👍

@janiceilene janiceilene added engineering Will involve Docs Engineering triage Do not begin working on this issue until triaged by the team labels Oct 12, 2020
@chiedo chiedo removed the engineering Will involve Docs Engineering label Oct 13, 2020
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! 🙂

Thanks for the PR, @tnir, I'll get this merged.

@lucascosti lucascosti self-assigned this Oct 14, 2020
@lucascosti lucascosti added ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team content This issue or pull request belongs to the Docs Content team labels Oct 14, 2020
@lucascosti lucascosti merged commit 014e7c7 into github:main Oct 14, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@tnir tnir deleted the ubuntu-latest-on-actions branch October 14, 2020 15:34
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* Remove reference to PR, and some light editing

* Update telegraf-output-plugin.md

writes them

* Update telegraf-output-plugin.md

Co-authored-by: Jacob Prall <prall.jacob@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants