GitHub Actions: Be precise about the format #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I stumbled across this to add the plain branch name to the [Docker push action](https://github.com/docker/build-push-action) as a tag, which does not work with ```yaml with: tags: tillepille/my-image: ${{ github.ref }} ```
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
|
Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review! |
|
@janiceilene Sorry, I missed it when opening the mr via whole UI workflow. Filled out, Issue also created |
|
Thanks so much for filling out the template and opening an issue @tillepille 💛 I'll get this triaged for review! |
janiceilene
added
actions
lucascosti
reviewed
Oct 20, 2020
content/actions/reference/context-and-expression-syntax-for-github-actions.md
Outdated
Show resolved
Hide resolved
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled across this to add the plain branch name to the Docker push action as a tag, which does not work with
Why:
I tried to get the plain branch name as a variable in my Action. The documentation suggested to me that this is the plain branch name e.g.
masterbut it is in the format ofrefs/heads/masterwhich isn't applicable as e.g a docker tag.What's being changed:
Be more precise about the format of the variable.
I added in the form of
refs/heads/<BRANCH_NAME>to the explanation.Check off the following:
closes #476