Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference link of user_email.mark_as_unclaimed GitHub Audit log event #35096

Conversation

AdrianDsg
Copy link

Why:

Discovered invalid contents in docs_reference_links attribute value of user_email.mark_as_unclaimed GitHub Audit log event.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Please see above.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Oct 29, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • src/audit-logs/data/fpt/user.json
  • src/audit-logs/data/ghec/enterprise.json
  • src/audit-logs/data/ghec/user.json
  • src/audit-logs/data/ghes-3.14/enterprise.json
  • src/audit-logs/data/ghes-3.14/user.json
  • src/audit-logs/data/ghes-3.15/enterprise.json
  • src/audit-logs/data/ghes-3.15/user.json

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 29, 2024
@nguyenalex836
Copy link
Contributor

Hello @AdrianDsg 👋 ! Thank you for opening a PR!

While we are unable to accept changes to these files per the comment above, we will open an issue internally for our team to review 💛 Thank you for willingness to contribute to GitHub Docs! ✨

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants