-
Notifications
You must be signed in to change notification settings - Fork 60.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependabot supports npm indirect dependency updating #26493
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@Bo98 Thanks so much for opening a PR! I'll get this triaged for review ⚡ And welcome to the community! 🎉 If you're looking for ways to contribute while this is waiting for review, please take a look at our help wanted section to find open issues you can work on. |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
Hi @Bo98 👋🏻 - thanks for submitting this update. I will double-check with the relevant team at GitHub and will get back to you once I've heard from them. Thanks for your patience! |
Hi @Bo98 - I've reached out to the Dependabot Updates team and unfortunately, we cannot accept this contribution as this npm support is only valid for Dependabot security updates, not Dependabot version updates. |
Thanks for checking out with the team! That's interesting, I added |
@Bo98 - thanks so much for the context, I'll let the team know. Looks like this is a bug. |
Why:
Dependabot appears to be able to tag indirect npm dependencies fine: Homebrew/actions@e9d995f
Adding:
to
dependabot.yml
does change the Dependabot update behaviour to include indirect dependencies, soall
definitely doesn't do nothing like the docs currently seem to imply.I'm not sure if there's any caveats in the support in terms of lockfile versions etc.
What's being changed (if available, include any code snippets, screenshots, or gifs):
The list of eco-systems that support indirect updates.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.