Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODEOWNERS file syntax documentation edited to make it explicitly clear that a pattern can only be used once #24211

Merged
merged 6 commits into from
Mar 2, 2023
Merged

CODEOWNERS file syntax documentation edited to make it explicitly clear that a pattern can only be used once #24211

merged 6 commits into from
Mar 2, 2023

Conversation

OlayinkaAtobiloye
Copy link
Contributor

@OlayinkaAtobiloye OlayinkaAtobiloye commented Feb 28, 2023 •
edited
Loading

Why:

Closes #17058

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 28, 2023
@OlayinkaAtobiloye
Copy link
Contributor Author

Hi @cmwilson21! Created a PR for this issue. Please check it out when chanced!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
 fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@OlayinkaAtobiloye awesome! I'll get this triaged for review! Thank you ✨

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review code owners Content related to code owners repositories Content related to repositories and removed triage Do not begin working on this issue until triaged by the team labels Mar 1, 2023
jc-clark
jc-clark approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@jc-clark jc-clark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me @OlayinkaAtobiloye! Thank you for adding this ✨

@cmwilson21 cmwilson21 added the ready to merge This pull request is ready to merge label Mar 2, 2023
@cmwilson21 cmwilson21 enabled auto-merge March 2, 2023 16:08
@cmwilson21 cmwilson21 merged commit 5a5e6cd into github:main Mar 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@OlayinkaAtobiloye OlayinkaAtobiloye deleted the codeowners branch March 25, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jc-clark jc-clark jc-clark approved these changes

Assignees
No one assigned
Labels
code owners Content related to code owners content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge repositories Content related to repositories waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CODEOWNERS file syntax documentation does not make it explicitly clear that a pattern can only be used once
3 participants
@OlayinkaAtobiloye @cmwilson21 @jc-clark