Skip to content

Update about-github-education.md #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 31, 2021
Merged

Update about-github-education.md #2172

merged 18 commits into from
Mar 31, 2021

Conversation

bassa846
Copy link
Contributor

@jen-k @dgyani

Why: Updating new content for the About GitHub Education Doc landing page

What's being changed: Removed a few sentences of this page, to the appropriate pages such as the Campus Advisors landing page and the Campus Experts landing page.

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@ghost

This comment has been minimized.

Sign in to view
ghost
ghost previously approved these changes Dec 20, 2020
View reviewed changes
@janiceilene
Copy link
Contributor

👋 Hey folks! Whenever we change the name of an article, it takes a bit more background work (updating index files, adding redirects, etc). If this is a change you all want to make, let me know and we'll have a writer make the additional updates 💖

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Dec 21, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 28, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 28, 2020
@dgyani
Copy link

dgyani commented Dec 29, 2020

👋 Hey folks! Whenever we change the name of an article, it takes a bit more background work (updating index files, adding redirects, etc). If this is a change you all want to make, let me know and we'll have a writer make the additional updates 💖

hi @janiceilene that will be great! we will be happy to work with the writer if required.

jebobite
jebobite previously approved these changes Dec 31, 2020
View reviewed changes
@hubwriter
Copy link
Contributor

@bassa846 - Thank you for contributing to the GitHub documentation. You've raised 3 PRs to change 3 files:

As these are all part of the same piece of work I've closed the other 2 PRs and merged those changes into this PR so that we can deal with this in one place, and merge all of these changes at the same time.

This was referenced Jan 7, 2021
Closed
Closed
@janiceilene
Copy link
Contributor

@bassa846 @jen-k @dgyani You all are the subject matter experts on education 🙇‍♀️ so we'll wait until we get the go ahead from you 👍 before we start a writer review (where we'll align the content with our style guides, localization requirements, etc)!

Can someone ping me back in once you're ready? Thank you!!

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 14, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 14, 2021
Alokrar
Alokrar reviewed Mar 17, 2021
View reviewed changes
Copy link

@Alokrar Alokrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

@saritai saritai self-requested a review March 24, 2021 16:20
@saritai saritai self-assigned this Mar 24, 2021
@saritai saritai dismissed stale reviews from ghost , jebobite, and ghost via a5705de March 30, 2021 14:57
@saritai
Copy link
Contributor

saritai commented Mar 30, 2021 •
edited
Loading

@jen-k @bassa846 Thanks so much for your contribution! I have reviewed your changes and they look good. I also did the indexing changes and pushed those to this PR - changed the article slug and title, and updated some of the variables in a few articles to use the Campus Program variable that already existed. I am going to get an internal writer review of my updates, and once approved, I will go ahead and merge!

@saritai saritai removed their request for review March 30, 2021 17:20
shati-patel
shati-patel previously approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @saritai! I've left one small suggestion, but the title change and variables look great 🎉

@saritai @shati-patel
Split one sentence into two
f9018e1 
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
@saritai saritai dismissed stale reviews from shati-patel and ghost via f9018e1 March 31, 2021 15:13
shati-patel
shati-patel approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this addition! 🎉 Looks good to merge :shipit:

@saritai saritai merged commit 696726a into main Mar 31, 2021
@saritai saritai deleted the bassa846-patch-1-1 branch March 31, 2021 16:38
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@bassa846
Copy link
Contributor Author

bassa846 commented Apr 7, 2021

@janiceilene Hi Janice 😄

Wondering if we can add an FAQ section to bottom portion of the "About GitHub Campus Program" page. If so please let me know what is the best way to go about this addition. I have a drafted FAQ that I can share with a writer.

@emilyistoofunky
Copy link
Member

Hi @bassa846! We can definitely help with getting some information into "About GitHub Campus Program." If it's information that can be shared here in our public docs repository, then feel free to open an issue here. If you'd rather discuss/implement it privately, you can open an issue in our docs-content repository instead (DM me on Slack if you don't have access to it and we can work on that!).

Heads-up that we don't use FAQs as a content type on our docs, so would likely rework the information into a format we use. (Here are some links about why we don't use FAQs in case you're interested! 1, 2)

Let me know if you have any questions!

@bassa846
Copy link
Contributor Author

bassa846 commented Apr 9, 2021

@emilyistoofunky thank you! I just opened the issue.

ghost
ghost reviewed Apr 29, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Looks good this, It have clear mentioned about the campus program and benefits.

rarajb790099
rarajb790099 reviewed Apr 29, 2021
View reviewed changes
Copy link

@rarajb790099 rarajb790099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content://com.google.android.apps.nbu.files.provider/2/61215 #5831

This was referenced May 12, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubwriter hubwriter hubwriter left review comments

@Alokrar Alokrar Alokrar left review comments

@rarajb790099 rarajb790099 rarajb790099 left review comments

@shati-patel shati-patel shati-patel approved these changes

@jen-k jen-k jen-k left review comments

@jebobite jebobite jebobite left review comments

Assignees

@jen-k jen-k

@bassa846 bassa846

@dgyani dgyani

@saritai saritai

Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.