Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon ECS / Azure App Service deployment guides #2088

Closed
wants to merge 3 commits into from

Conversation

swinton
Copy link
Contributor

@swinton swinton commented Dec 14, 2020

Why:

Building on #2085, adds deployment guides for Amazon ECS / Azure App Service as part of a group of select partner deployment guides.

/cc @runleonarun, @imjohnbo, @jpadams 👋

What's being changed:

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link

welcome bot commented Dec 14, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@swinton swinton self-assigned this Dec 14, 2020
@swinton swinton marked this pull request as ready for review December 14, 2020 23:25
@imjohnbo
Copy link
Contributor

@swinton, I think you might also need to add links to these guides in this list

@jpadams
Copy link

jpadams commented Dec 15, 2020

@swinton I don't see the Guides linked in the preview enviro deploy like I do in the one @imjohnbo deployed.

#2085 (comment)

@swinton
Copy link
Contributor Author

swinton commented Dec 15, 2020

@swinton, I think you might also need to add links to these guides in this list

@swinton I don't see the Guides linked in the preview enviro deploy like I do in the one @imjohnbo deployed.

Thanks both. I think we should close this PR and I'll add my commits to @imjohnbo's PR directly, so we don't have any merge conflicts in that file. That 🆒 with you, @imjohnbo?

@swinton
Copy link
Contributor Author

swinton commented Dec 15, 2020

Should be there now:

image

@swinton
Copy link
Contributor Author

swinton commented Dec 16, 2020

I'll add my commits to @imjohnbo's PR directly, so we don't have any merge conflicts in that file. That 🆒 with you, @imjohnbo?

Continuing this work under a single PR: #2085

See you there 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants