-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GKE, Amazon ECS, and Azure App Service deployment guides #2085
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@imjohnbo LGTM in the preview environment! |
Hi @imjohnbo 👋 - Thanks for this great guide! I've added some small edits and structural changes to the draft. Could you check that you're happy with my changes? The rendered preview is here: https://docs-2085--deployment-guidesad.herokuapp.com/en/free-pro-team@latest/actions/guides/deploying-to-google-kubernetes-engine |
content/actions/guides/deploying-to-google-kubernetes-engine.md
Outdated
Show resolved
Hide resolved
This looks great to me, @martin389. Thanks for the quick review. 🙏 |
Thanks Docs team for the assistance and improvements! 🙌 We'd love to get these published as soon as possible to support the current DevOps campaign and our goal to deliver these three initial deploy guides this quarter to support an ask from Jeremy Epling in https://github.com/github/business-development/issues/980. |
@jpadams It looks like we need to edit the two newly added guides. Martin is OOO but @lucascosti will so kindly edit them so we can ship ASAP. 💐 |
There was an error handling pipeline event d0768bc1-5c4b-4d43-af04-45f8b9cd6354. |
👋 @imjohnbo, @jpadams, @swinton! Thanks again for this great content 🙇♂️. I've done edits of the Azure and Amazon ECS guide drafts to fit in with our docs style and structure. Could you please have a look and make sure I haven't changed the meaning of anything? In particular, for some example code blocks, I changed the user-replaceable values that looked like environment variables (e.g. Rendered previews can be seen on the stage:
@martin389 / @runleonarun I'd love to get a proofread on my changes as well before these are published 🙂 Also note that I haven't personally tested these procedures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lucascosti. A couple of suggestions from me 🙇
content/actions/guides/deploying-to-amazon-elastic-container-service.md
Outdated
Show resolved
Hide resolved
content/actions/guides/deploying-to-amazon-elastic-container-service.md
Outdated
Show resolved
Hide resolved
…ervice.md Co-authored-by: Steve Winton <swinton@github.com>
…ervice.md Co-authored-by: Steve Winton <swinton@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a tiny typo otherwise this is ready to ship!
content/actions/guides/deploying-to-amazon-elastic-container-service.md
Outdated
Show resolved
Hide resolved
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this config file contains all config fields with comments
NOTE: this is not a particularly useful config file
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
patch the generated kubeadm config with some extra settings
kubeadmConfigPatches:
- |
apiVersion: kubelet.config.k8s.io/v1beta1
kind: KubeletConfiguration
evictionHard:
nodefs.available: "0%"
patch it further using a JSON 6902 patch
kubeadmConfigPatchesJSON6902:
- group: kubeadm.k8s.io
version: v1beta2
kind: ClusterConfiguration
patch: |- op: add
path: /apiServer/certSANs/-
value: my-hostname
- op: add
1 control plane node and 3 workers
nodes:
the control plane node config
- role: control-plane
the three workers
- role: worker
- role: worker
- role: worker
Why:
Google Kubernetes Engine deployment guide as part of a group of select partner deployment guides.
cc/ @runleonarun, @swinton, @jpadams 👋
What's being changed:
Check off the following: