Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GKE, Amazon ECS, and Azure App Service deployment guides #2085

Merged
merged 22 commits into from
Dec 17, 2020

Conversation

imjohnbo
Copy link
Contributor

Why:

Google Kubernetes Engine deployment guide as part of a group of select partner deployment guides.

cc/ @runleonarun, @swinton, @jpadams 👋

What's being changed:

  • Added a new section to this page to include continuous deployment (CD):

  • Added a new "deployment guide" for Google Kubernetes Engine based on the existing starter workflow.

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link

welcome bot commented Dec 14, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@jpadams
Copy link

jpadams commented Dec 15, 2020

@imjohnbo LGTM in the preview environment!
image

@martin389 martin389 self-requested a review December 16, 2020 06:08
@martin389
Copy link
Contributor

Hi @imjohnbo 👋 - Thanks for this great guide! I've added some small edits and structural changes to the draft. Could you check that you're happy with my changes?

The rendered preview is here: https://docs-2085--deployment-guidesad.herokuapp.com/en/free-pro-team@latest/actions/guides/deploying-to-google-kubernetes-engine

@imjohnbo
Copy link
Contributor Author

Hi @imjohnbo 👋 - Thanks for this great guide! I've added some small edits and structural changes to the draft. Could you check that you're happy with my changes?

The rendered preview is here: https://docs-2085--deployment-guidesad.herokuapp.com/en/free-pro-team@latest/actions/guides/deploying-to-google-kubernetes-engine

This looks great to me, @martin389. Thanks for the quick review. 🙏

@swinton swinton self-assigned this Dec 16, 2020
@imjohnbo imjohnbo changed the title Add GKE deployment guide Add GKE, Amazon ECS, and Azure App Service deployment guides Dec 16, 2020
@janiceilene janiceilene added the ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team label Dec 16, 2020
@jpadams
Copy link

jpadams commented Dec 16, 2020

Thanks Docs team for the assistance and improvements! 🙌 We'd love to get these published as soon as possible to support the current DevOps campaign and our goal to deliver these three initial deploy guides this quarter to support an ask from Jeremy Epling in https://github.com/github/business-development/issues/980.

cc @kathrynhsu @crichID

@runleonarun
Copy link
Contributor

@jpadams It looks like we need to edit the two newly added guides. Martin is OOO but @lucascosti will so kindly edit them so we can ship ASAP. 💐

@azure-pipelines
Copy link

There was an error handling pipeline event d0768bc1-5c4b-4d43-af04-45f8b9cd6354.

@lucascosti
Copy link
Contributor

lucascosti commented Dec 17, 2020

👋 @imjohnbo, @jpadams, @swinton!

Thanks again for this great content 🙇‍♂️. I've done edits of the Azure and Amazon ECS guide drafts to fit in with our docs style and structure.

Could you please have a look and make sure I haven't changed the meaning of anything?

In particular, for some example code blocks, I changed the user-replaceable values that looked like environment variables (e.g. $ECR_REPOSITORY), to be a more obvious a user-replaceable value (e.g. MY_ECR_REPOSITORY). If I'm mistaken and these do actually need to be environment variables, please let me know 😅.

Rendered previews can be seen on the stage:

@martin389 / @runleonarun I'd love to get a proofread on my changes as well before these are published 🙂 Also note that I haven't personally tested these procedures.

Copy link
Contributor

@swinton swinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucascosti. A couple of suggestions from me 🙇

runleonarun and others added 2 commits December 17, 2020 13:01
…ervice.md

Co-authored-by: Steve Winton <swinton@github.com>
…ervice.md

Co-authored-by: Steve Winton <swinton@github.com>
Copy link
Contributor

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a tiny typo otherwise this is ready to ship!

@runleonarun runleonarun added the ready to merge This pull request is ready to merge label Dec 17, 2020
@runleonarun
Copy link
Contributor

@jpadams @swinton and @imjohnbo We can merge this today. It looks good! Thanks for the team work! 👥

@runleonarun runleonarun merged commit 4ce9eab into main Dec 17, 2020
@runleonarun runleonarun deleted the deployment-guides/add-gke branch December 17, 2020 21:22
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Copy link

@iCG-SE iCG-SE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this config file contains all config fields with comments

NOTE: this is not a particularly useful config file

kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4

patch the generated kubeadm config with some extra settings

kubeadmConfigPatches:

  • |
    apiVersion: kubelet.config.k8s.io/v1beta1
    kind: KubeletConfiguration
    evictionHard:
    nodefs.available: "0%"

patch it further using a JSON 6902 patch

kubeadmConfigPatchesJSON6902:

  • group: kubeadm.k8s.io
    version: v1beta2
    kind: ClusterConfiguration
    patch: |
    • op: add
      path: /apiServer/certSANs/-
      value: my-hostname

1 control plane node and 3 workers

nodes:

the control plane node config

  • role: control-plane

the three workers

  • role: worker
  • role: worker
  • role: worker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants