-
Notifications
You must be signed in to change notification settings - Fork 62.2k
Specify return value for undefined properties in workflow contexts #17089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
@rossjrw |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
This is a gentle bump for the docs team that this PR is waiting for technical review. |
Thanks @rossjrw - I added a minor suggestion but this is a helpful improvement! 🎉 |
Co-authored-by: Edward Thomson <ethomson@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rossjrw - thanks for this improvement to the page 💖
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
The documentation for workflows doesn't mention what happens when you access a nonexistent property. This is important to know - maybe it throws an error? It returns an empty string, so mentioning it will save someone an experiment to find out.
What's being changed:
Add a line to https://docs.github.com/en/actions/learn-github-actions/contexts.
Could possibly be more appropriate for https://docs.github.com/en/actions/learn-github-actions/expressions; however, I don't think there's a way to access a property in an expression without going via a context, so this seems fine.
Check off the following:
Writer impact (This section is for GitHub staff members only):