repo sync #16744
Merged
repo sync #16744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les to links (#26360) * Add cta button to frontmatter and context * Add cta to Page * Render cta button in product landing hero * Handle external links * Add simple unit test for cta link * Address feedback Co-authored-by: Peter Bengtsson <mail@peterbe.com> * Actually push condition update * Show it's an external link * Refactor FullLink so we use Link once Co-authored-by: Peter Bengtsson <mail@peterbe.com> * Custom link can also be null * Rename 'cta' to 'custom' and make it the last introLink * Update tests with 'cta' to 'custom' change * Filter once * Revert "Filter once" This reverts commit a3f9a8a06b505d77fed47ca96a66c187c86c3c91. * Update introLinks to a map of titles and URLs * No more custom introLink in LandingHero * Simplify introLinks processing * introLinks can also be null Co-authored-by: Peter Bengtsson <mail@peterbe.com> * more concise Co-authored-by: Peter Bengtsson <mail@peterbe.com> * No longer necessary with the a plain introLinks map Co-authored-by: Peter Bengtsson <mail@peterbe.com> * '.entries()` is simpler Co-authored-by: Peter Bengtsson <mail@peterbe.com> * 'link' could be false depending on what version you're on * Update test for new introLinks Co-authored-by: Peter Bengtsson <mail@peterbe.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to sync changes between the public and private repos.
🤖 This pull request should be merged (not squashed) to preserve continuity across repos, so please let a bot do the merging!