Skip to content

Fix maven code example to match instructions #16563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2022
Merged

Fix maven code example to match instructions #16563

merged 4 commits into from
Apr 20, 2022

Conversation

dawinkweon
Copy link
Contributor

Why:

Closes #16562

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Mar 27, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/actions/automating-builds-and-tests/building-and-testing-java-with-maven.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Mar 28, 2022
@ramyaparimi
Copy link
Contributor

@dawinkweon
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added the needs SME This proposal needs review from a subject matter expert label Mar 28, 2022
@ethomson
Copy link
Contributor

ethomson commented Apr 6, 2022

Good catch @dawinkweon - thanks for the fix. LGTM.

@ramyaparimi ramyaparimi added SME reviewed An SME has reviewed this issue/PR and removed needs SME This proposal needs review from a subject matter expert labels Apr 7, 2022
@dawinkweon
Copy link
Contributor Author

@ethomson Hi there, could we get an approval to get this in? Thanks, Dawin.

ramyaparimi
ramyaparimi approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to merge after tech review ✨

@ramyaparimi ramyaparimi merged commit 64dfcb2 into github:main Apr 20, 2022
@ramyaparimi ramyaparimi added the ready to merge This pull request is ready to merge label Apr 20, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@Casstarlove Casstarlove mentioned this pull request Nov 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramyaparimi ramyaparimi ramyaparimi approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge SME reviewed An SME has reviewed this issue/PR waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maven code example has wrong target
3 participants
@dawinkweon @ramyaparimi @ethomson