Skip to content

Fix broken title #16456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2022
Merged

Fix broken title #16456

merged 2 commits into from
Mar 22, 2022

Conversation

nhedger
Copy link
Contributor

@nhedger nhedger commented Mar 22, 2022

Why:

Fix a broken title.

I suspect a newline between {% endpowershell %} and the title is needed, otherwise, the title does not render properly.

Screenshot 2022-03-22 at 13 02 28

What's being changed:

Adds a newline before the ## Grouping log lines title.

@welcome
Copy link

welcome bot commented Mar 22, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/actions/using-workflows/workflow-commands-for-github-actions.md Modified Original

@nhedger
Copy link
Contributor Author

nhedger commented Mar 22, 2022

I've checked the modification on the preview environment and the change restores the title as expected.

ramyaparimi
ramyaparimi approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhedger
Thanks so much for opening a PR with this fix! I'll get this merged once tests are passing 🍏

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Mar 22, 2022
@ramyaparimi ramyaparimi enabled auto-merge March 22, 2022 14:27
@ramyaparimi ramyaparimi merged commit 04f9e9e into github:main Mar 22, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@nhedger nhedger deleted the patch-2 branch March 22, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramyaparimi ramyaparimi ramyaparimi approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhedger @ramyaparimi