Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specify registry specific path #1602

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Conversation

jcansdale
Copy link
Contributor

Why:

The authenticate-packages.md componet is used across all GitHub Package ecosystems. We shouldn't include the ecosystem specific path on the example.

Here are some ecosystem specific URLs that are used:

nuget.pkg.github.com/OWNER
maven.pkg.github.com/OWNER/REPOSITORY
docker.pkg.github.com/OWNER/REPOSITORY/IMAGE-NAME

We could generalize it to simply mention PACKAGE-REGISTRY.pkg.github.com.

What's being changed:

Change Docker specific PACKAGE-REGISTRY.pkg.github.com/OWNER/REPOSITORY/IMAGE-NAME to generic PACKAGE-REGISTRY.pkg.github.com.

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@jcansdale jcansdale added the packages This issue or pull request should be reviewed by the docs packages team label Nov 25, 2020
@janiceilene
Copy link
Contributor

Thanks @jcansdale! I'll get this triaged for review ⚡

@janiceilene janiceilene added the ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team label Nov 30, 2020
@janiceilene janiceilene added the content This issue or pull request belongs to the Docs Content team label Nov 30, 2020
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcansdale! I'll merge this now!✨

@lecoursen lecoursen merged commit 92a9511 into main Dec 2, 2020
@lecoursen lecoursen deleted the registry-specific-path branch December 2, 2020 20:36
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants