-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't specify registry specific path #1602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcansdale
added
the
packages
This issue or pull request should be reviewed by the docs packages team
label
Nov 25, 2020
Thanks @jcansdale! I'll get this triaged for review ⚡ |
janiceilene
added
the
ecosystem
This issue or pull request should be reviewed by the Docs Ecosystem team
label
Nov 30, 2020
janiceilene
added
the
content
This issue or pull request belongs to the Docs Content team
label
Nov 30, 2020
lecoursen
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcansdale! I'll merge this now!✨
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
This was referenced Jul 31, 2022
This was referenced Jul 31, 2022
This was referenced Aug 1, 2022
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The
authenticate-packages.md
componet is used across all GitHub Package ecosystems. We shouldn't include the ecosystem specific path on the example.Here are some ecosystem specific URLs that are used:
We could generalize it to simply mention
PACKAGE-REGISTRY.pkg.github.com
.What's being changed:
Change Docker specific
PACKAGE-REGISTRY.pkg.github.com/OWNER/REPOSITORY/IMAGE-NAME
to genericPACKAGE-REGISTRY.pkg.github.com
.Check off the following: