-
Notifications
You must be signed in to change notification settings - Fork 60.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note for missing sso contributions #15833
Conversation
@SteveDMurphy In the meantime, could you please provide link to the issue that's referenced in the OP of this PR? |
Thank you @ramyaparimi !! This PR actually stemmed from speaking with GitHub support, where I was told they had opened an internal issue around the change I am adding. That # in the OP was the ticket number from that conversation and I wanted to try and help if possible. I can create a public issue as well if that makes sense, thanks again for the help! |
Thanks so much for providing the background information. Thank you for taking your time in making this contribution 💖
Creating PR is just fine. You don't have create a public issue 💖 |
Thank you again @ramyaparimi ! Let me know if there is anything else I can do 🙌🏽 |
@SteveDMurphy Thanks for suggesting these improvements! Having the change as a note and in that specific section of the article doesn't quite fit in our style guide. However including that info in the "About" section of the article is certainly helpful to other users, so I'll commit a change to that effect and get this PR merged. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vgrl thanks for taking the time for this, love the changes you made - thank you! 🙌🏽 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes internal issue, reference ticket #
1497638
What's being changed:
Add a note about why contributions may appear to be missing from the contribution graph when made to a repository requiring sso (when not signed in)
Check off the following:
Writer impact (This section is for GitHub staff members only):