Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note for missing sso contributions #15833

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Feb 25, 2022

Why:

Closes internal issue, reference ticket # 1497638

What's being changed:

Add a note about why contributions may appear to be missing from the contribution graph when made to a repository requiring sso (when not signed in)

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 25, 2022
@ramyaparimi
Copy link
Contributor

@SteveDMurphy
Thanks so much for opening a PR! I'll get this triaged for review ⚡

In the meantime, could you please provide link to the issue that's referenced in the OP of this PR?

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 25, 2022
@SteveDMurphy
Copy link
Contributor Author

Thank you @ramyaparimi !!

This PR actually stemmed from speaking with GitHub support, where I was told they had opened an internal issue around the change I am adding. That # in the OP was the ticket number from that conversation and I wanted to try and help if possible. I can create a public issue as well if that makes sense, thanks again for the help!

@ramyaparimi
Copy link
Contributor

This PR actually stemmed from speaking with GitHub support, where I was told they had opened an internal issue around the change I am adding. That # in the OP was the ticket number from that conversation and I wanted to try and help if possible.

Thanks so much for providing the background information. Thank you for taking your time in making this contribution 💖

I can create a public issue as well if that makes sense, thanks again for the help!

Creating PR is just fine. You don't have create a public issue 💖

@SteveDMurphy
Copy link
Contributor Author

Thank you again @ramyaparimi ! Let me know if there is anything else I can do 🙌🏽

@vgrl vgrl self-assigned this Mar 1, 2022
@vgrl
Copy link
Contributor

vgrl commented Mar 4, 2022

@SteveDMurphy Thanks for suggesting these improvements!

Having the change as a note and in that specific section of the article doesn't quite fit in our style guide. However including that info in the "About" section of the article is certainly helpful to other users, so I'll commit a change to that effect and get this PR merged.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/account-and-profile/setting-up-and-managing-your-github-profile/managing-contribution-graphs-on-your-profile/why-are-my-contributions-not-showing-up-on-my-profile.md Modified Original

Copy link
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vgrl vgrl added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 4, 2022
@vgrl vgrl enabled auto-merge March 4, 2022 05:21
@SteveDMurphy
Copy link
Contributor Author

Having the change as a note and in that specific section of the article doesn't quite fit in our style guide. However including that info in the "About" section of the article is certainly helpful to other users, so I'll commit a change to that effect and get this PR merged.

@vgrl thanks for taking the time for this, love the changes you made - thank you! 🙌🏽

@vgrl vgrl merged commit 9c6b311 into github:main Mar 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants