Skip to content

Fix typo metadata-syntax-for-github-actions.md #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2020
Merged

Fix typo metadata-syntax-for-github-actions.md #1456

merged 2 commits into from
Dec 2, 2020

Conversation

cassshh
Copy link
Contributor

@cassshh cassshh commented Nov 19, 2020 •
edited
Loading

Fix typo for metadata-syntax-for-github-actions#outputs-for-composite-run-steps-actions

Why:

I expect this to be a mistake in the documentation.
Resolves #1455

What's being changed:

outputs.<output_id.value> -> outputs.<output_id>.value

Screenshot of current content:
(Red line is being changed)
Screenshot 2020-11-19 at 12 32 08

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@cassshh
Fix typo metadata-syntax-for-github-actions.md
1611264 
Fix typo for metadata-syntax-for-github-actions#outputs-for-composite-run-steps-actions
@welcome
Copy link

welcome bot commented Nov 19, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@cassshh Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 19, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 27, 2020
@cassshh
Copy link
Contributor Author

cassshh commented Nov 30, 2020

A friendly bump to keep the PR from being closed 🙂

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Nov 30, 2020
@janiceilene
Copy link
Contributor

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@shati-patel shati-patel self-assigned this Dec 2, 2020
shati-patel
shati-patel approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting that typo and fixing it, @cassshh 🎉 We really appreciate all the community contributions to help us improve our docs!

I'll get this merged shortly 😄

@shati-patel shati-patel merged commit 64aca19 into github:main Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@cassshh cassshh deleted the patch-1 branch December 2, 2020 14:29
@cassshh
Copy link
Contributor Author

cassshh commented Dec 2, 2020

Superb. Thank you both!

@Simran-B Simran-B mentioned this pull request Dec 14, 2020
Merged
4 tasks
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@charislam @Loquacity
Move info on restarting workers from KB (github#1456)
fb8a63f 
* Move info on restarting workers from KB

Move info on restarting background workers from the Knowledge Base. This
is useful for Cloud as well (and we don't have the fact that
`start_background_workers` doesn't work on these platforms documented),
so add it to general troubleshooting and Cloud troubleshooting.

Co-authored-by: Lana Brindley <github@lanabrindley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees

@shati-patel shati-patel

Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo about using outputs
3 participants
@cassshh @janiceilene @shati-patel