Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode #551

Closed
manula2004 opened this issue Oct 15, 2020 · 14 comments
Closed

Add dark mode #551

manula2004 opened this issue Oct 15, 2020 · 14 comments
Assignees
Labels
design Will involve design/engineering engineering Will involve Docs Engineering help wanted Anyone is welcome to open a pull request to fix this issue

Comments

@manula2004
Copy link

What is the current behavior?

Github docs website does not have a dark mode

What changes are you suggesting?

A lot of people, including myself prefer dark mode over light mode in a website . I think It makes the docs more comfortable to read for a user. So it would be really great to have a dark mode to the website.

Additional information

...

@manula2004 manula2004 added the engineering Will involve Docs Engineering label Oct 15, 2020
@welcome
Copy link

welcome bot commented Oct 15, 2020

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 15, 2020
@janiceilene janiceilene added the design Will involve design/engineering label Oct 15, 2020
@kishore007k
Copy link

I would love to work on this issue. If it is still open and available. @manula2004

@manula2004
Copy link
Author

@kishore007k yes, the issue is still open and available. It would be really great if you could work on this

@kishore007k
Copy link

@manula2004 Yes, I'm up for it. I came across the Readme file and found that the issue that has the triage lable is still not yet verified by the reviewers. @janiceilene If you would can you remove the triage label so that I could work on the issue?

@ESSA760
Copy link

ESSA760 commented Oct 18, 2020

Nice

@janiceilene
Copy link
Contributor

@kishore007k It hasn't been verified yet, thank you for checking! A member of the team will review it soon 💛

@kishore007k
Copy link

Looking forward to work on this issue. @janiceilene

@simpsoka
Copy link
Contributor

This is exciting. :)

I'd be happy to review what you're thinking @kishore007k! We are going through a little bit of a redesign - which you see us doing on the GitHub Actions pages. It's iterative, so if you want to start there, I think that'd be good.

@RubyDevil
Copy link

hi i want to work :(

@chiedo chiedo added help wanted Anyone is welcome to open a pull request to fix this issue and removed triage Do not begin working on this issue until triaged by the team labels Nov 30, 2020
@kazuhitonakayama
Copy link
Contributor

It's an honor to meet you all!
How is the issue progressing here?
I'm contacting you because I'd like to help!✨
@simpsoka @janiceilene @manula2004

@GroovinChip
Copy link

Hello, is there any movement on this? The docs are super blinding to me and my dark mode browser extension doesn't work with the docs for some reason (Dark Reader).

@simpsoka
Copy link
Contributor

Thanks for asking, @GroovinChip! We're going through a redesign on the site right now and as that reaches a solid state we'll look into dark mode.

@GroovinChip
Copy link

Thanks for asking, @GroovinChip! We're going through a redesign on the site right now and as that reaches a solid state we'll look into dark mode.

Thanks for the response! Do you have a general timeframe for when we can expect this? I know that's a hard question, sorry 😅

Would you know why Dark Reader doesn't work with the site? Is it something I can fix on my end?

@simpsoka
Copy link
Contributor

Thanks for the response! Do you have a general timeframe for when we can expect this? I know that's a hard question, sorry 😅

No problem! We're not looking at adding dark mode any time soon - though that could change if we're able to get through the new design earlier. I'm going to go ahead and close this issue out, though, since it's not on our immediate roadmap.

Would you know why Dark Reader doesn't work with the site? Is it something I can fix on my end?

I'm not sure why it's not working, I haven't had a chance to play around with it myself. I recommend opening up a discussion and seeing of others have played around with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Will involve design/engineering engineering Will involve Docs Engineering help wanted Anyone is welcome to open a pull request to fix this issue
Projects
None yet
Development

No branches or pull requests

10 participants