Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sophisticated example for hashFiles function #32305

Open
1 task done
Tracked by #33462
hamirmahal opened this issue Mar 30, 2024 · 9 comments
Open
1 task done
Tracked by #33462

More sophisticated example for hashFiles function #32305

hamirmahal opened this issue Mar 30, 2024 · 9 comments
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR stale There is no recent activity on this issue or pull request

Comments

@hamirmahal
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/learn-github-actions/expressions#hashfiles

What part(s) of the article would you like to see updated?

I think it'd be beneficial if the hashFiles function showed slightly more sophisticated examples.

For example, what if I want to invalidate the cache any time .rs files at the top level of the src/ directory change?

I.e., I'd like to invalidate the cache if src/main.rs or src/constants.rs change, but not if anything in src/misc/ changes.

src/
├── constants.rs
├── main.rs
└── misc
    ├── main.rs

Additional information

No response

@hamirmahal hamirmahal added the content This issue or pull request belongs to the Docs Content team label Mar 30, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 30, 2024
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 1, 2024
@nguyenalex836
Copy link
Contributor

@hamirmahal Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@hamirmahal
Copy link
Contributor Author

@nguyenalex836 You're welcome!

@nguyenalex836 nguyenalex836 added needs SME This proposal needs review from a subject matter expert test-create-tracking-issue Creates and links an SME review tracking issue internally labels Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836
Copy link
Contributor

@hamirmahal Thank you for your patience while our team reviewed! ✨

Our engineering believes adding these additional, more complex examples makes sense. Some experimentation may be necessary to figure out what patterns actually work and what scenarios GitHub supports 💛

Aside from the scenario you listed initially, do you have a list of more sophisticated scenarios you were looking to add?

@nguyenalex836 nguyenalex836 added more-information-needed More information is needed to complete review SME reviewed An SME has reviewed this issue/PR and removed needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review labels Apr 11, 2024
@hamirmahal
Copy link
Contributor Author

@nguyenalex836 You're welcome!

@hamirmahal
Copy link
Contributor Author

I can't think of any more sophisticated scenarios at the moment, but I'll post them if I think of any.

@nguyenalex836
Copy link
Contributor

@hamirmahal Sounds like a plan ✨ For now, I'm adding our help wanted label to this issue. You, or anyone else, are welcome to submit a PR with the example regarding hashFiles function for review 💛

@nguyenalex836 nguyenalex836 added help wanted Anyone is welcome to open a pull request to fix this issue and removed more-information-needed More information is needed to complete review labels Apr 11, 2024
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jun 11, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 18, 2024
@hamirmahal
Copy link
Contributor Author

@nguyenalex836 I don't think I know enough about the hashFiles function to contribute docs for it; it's why I opened this issue.

Is anyone from the team able to contribute them?

@nguyenalex836
Copy link
Contributor

@hamirmahal Apologies! Our overzealous bot closed this issue - I've just reopened so that a community member can pick this issue up 💛

@nguyenalex836 nguyenalex836 reopened this Jun 18, 2024
@nguyenalex836 nguyenalex836 removed the stale There is no recent activity on this issue or pull request label Jun 18, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 18, 2024
@nguyenalex836 nguyenalex836 removed the triage Do not begin working on this issue until triaged by the team label Jun 18, 2024
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Aug 19, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
@nguyenalex836 nguyenalex836 reopened this Aug 27, 2024
@nguyenalex836 nguyenalex836 removed stale There is no recent activity on this issue or pull request test-create-tracking-issue Creates and links an SME review tracking issue internally labels Aug 27, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 27, 2024
@nguyenalex836 nguyenalex836 removed the triage Do not begin working on this issue until triaged by the team label Aug 27, 2024
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR stale There is no recent activity on this issue or pull request
Projects
None yet
Development

No branches or pull requests

2 participants