Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note tags reset ordered list numbering #1552

Closed
jeffmaher opened this issue Nov 22, 2020 · 2 comments
Closed

note tags reset ordered list numbering #1552

jeffmaher opened this issue Nov 22, 2020 · 2 comments
Labels
engineering Will involve Docs Engineering triage Do not begin working on this issue until triaged by the team

Comments

@jeffmaher
Copy link

What is the current behavior?

It seems that {% note %} / {% endnote %} tags reset number when rendered in docs pages. This behaviour manifests in the final generated page, although it does not appear in the GitHub web editor preview tab.

An example page is:

The numbering reset is visible after the first note and after any subsequent note.

Screen Shot 2020-11-22 at 14 38 00

What changes are you suggesting?

Allow ordered list numbering to continue past a note.

Additional information

If there's any other info I can provide, let me know.

@jeffmaher jeffmaher added the engineering Will involve Docs Engineering label Nov 22, 2020
@welcome
Copy link

welcome bot commented Nov 22, 2020

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 22, 2020
@janiceilene
Copy link
Contributor

janiceilene commented Nov 23, 2020

Thanks so much for opening an issue @jeffmaher! There was an internal PR that was causing <li> elements to break when there were notes between steps. The PR was reverted and this article looks right to me now, so I'm going to close this out 🎉

Feel free to re-open if the issue isn't resolved or if I misunderstood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

No branches or pull requests

2 participants