Skip to content

Commit d6dcc42

Browse files
committed
Default to tests running if the skip action errors out
1 parent 6eac005 commit d6dcc42

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

.github/workflows/browser-test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@ jobs:
2424
steps:
2525
# Each of these ifs needs to be repeated at each step to make sure the required check still runs
2626
# Even if if doesn't do anything
27-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
27+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
2828
name: Checkout
2929
uses: actions/checkout@a81bbbf8298c0fa03ea29cdc473d45769f953675
3030

31-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
31+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
3232
name: Install
3333
uses: ianwalter/puppeteer@12728ddef82390d1ecd4732fb543f62177392fbb
3434
with:
3535
args: npm ci
3636

37-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
37+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
3838
name: Test
3939
uses: ianwalter/puppeteer@12728ddef82390d1ecd4732fb543f62177392fbb
4040
with:

.github/workflows/test.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -34,23 +34,23 @@ jobs:
3434
steps:
3535
# Each of these ifs needs to be repeated at each step to make sure the required check still runs
3636
# Even if if doesn't do anything
37-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
37+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
3838
name: Check out repo
3939
uses: actions/checkout@a81bbbf8298c0fa03ea29cdc473d45769f953675
4040

41-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
41+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
4242
name: Setup node
4343
uses: actions/setup-node@56899e050abffc08c2b3b61f3ec6a79a9dc3223d
4444
with:
4545
node-version: 14.x
4646

47-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
47+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
4848
name: Get npm cache directory
4949
id: npm-cache
5050
run: |
5151
echo "::set-output name=dir::$(npm config get cache)"
5252
53-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
53+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
5454
name: Cache node modules
5555
uses: actions/cache@d1255ad9362389eac595a9ae406b8e8cb3331f16
5656
with:
@@ -59,15 +59,15 @@ jobs:
5959
restore-keys: |
6060
${{ runner.os }}-node-
6161
62-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
62+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
6363
name: Install dependencies
6464
run: npm ci
6565

66-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
66+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
6767
name: Run linter
6868
run: npx standard
6969

70-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
70+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
7171
name: Check dependencies
7272
run: npm run check-deps
7373
test:
@@ -80,23 +80,23 @@ jobs:
8080
steps:
8181
# Each of these ifs needs to be repeated at each step to make sure the required check still runs
8282
# Even if if doesn't do anything
83-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
83+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
8484
name: Check out repo
8585
uses: actions/checkout@a81bbbf8298c0fa03ea29cdc473d45769f953675
8686

87-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
87+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
8888
name: Setup node
8989
uses: actions/setup-node@56899e050abffc08c2b3b61f3ec6a79a9dc3223d
9090
with:
9191
node-version: 14.x
9292

93-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
93+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
9494
name: Get npm cache directory
9595
id: npm-cache
9696
run: |
9797
echo "::set-output name=dir::$(npm config get cache)"
9898
99-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
99+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
100100
name: Cache node modules
101101
uses: actions/cache@d1255ad9362389eac595a9ae406b8e8cb3331f16
102102
with:
@@ -105,15 +105,15 @@ jobs:
105105
restore-keys: |
106106
${{ runner.os }}-node-
107107
108-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
108+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
109109
name: Install dependencies
110110
run: npm ci
111111

112-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
112+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
113113
name: Run build script
114114
run: npm run build
115115

116-
- if: ${{ needs.see_if_should_skip.outputs.should_skip == 'false' }}
116+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
117117
name: Run tests
118118
run: npx jest tests/${{ matrix.test-group }}/
119119

0 commit comments

Comments
 (0)