Skip to content

Fix invalid devcontainer.json #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Fix invalid devcontainer.json #1

merged 1 commit into from
Nov 17, 2022

Conversation

Chuxel
Copy link
Contributor

@Chuxel Chuxel commented Nov 17, 2022

A number of these templates are missing an image reference, which means they won't work anywhere outside of Codespaces, including in the Dev Container GitHub Action.

If the goal is to use the "kitchen sink" image, all that is needed is a reference to the image. This will be slow in other scenarios, but won't fail like it would today.

@joshaber joshaber merged commit 3bee689 into github:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants