Rust: Add numeric type barriers for three queries #20740
+232
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds numeric type barriers to three security queries (rust/regex-injection, rust/sql-injection, and rust/log-injection) to reduce false positives. The implementation introduces type classification classes in Builtins.qll to distinguish between numeric types (integral and floating-point) and uses these to create taint flow barriers.
Key Changes
- Introduces
NumericType,IntegralType, andFloatingPointTypeclass hierarchies inBuiltins.qll - Adds shared barrier classes in a new
Barriers.qllmodule for numeric and integral/boolean types - Integrates type-based barriers into the three security queries to prevent false positives when user input is converted to numeric types
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/frameworks/stdlib/Builtins.qll | Refactors builtin integer and float types to extend new numeric type hierarchy classes |
| rust/ql/lib/codeql/rust/security/Barriers.qll | Adds new shared barrier classes based on numeric and integral/boolean types |
| rust/ql/lib/codeql/rust/security/regex/RegexInjectionExtensions.qll | Integrates IntegralOrBooleanTypeBarrier to prevent false positives |
| rust/ql/lib/codeql/rust/security/SqlInjectionExtensions.qll | Integrates NumericTypeBarrier to prevent false positives |
| rust/ql/lib/codeql/rust/security/LogInjectionExtensions.qll | Integrates NumericTypeBarrier to prevent false positives |
| rust/ql/test/query-tests/security/CWE-117/main.rs | Adds test case for numeric data derived from user input |
| rust/ql/test/query-tests/security/CWE-089/sqlx.rs | Removes spurious alert annotation from numeric test case |
| rust/ql/test/query-tests/security/CWE-020/main.rs | Adds test case for numeric user input in regex construction |
| rust/ql/test/library-tests/elements/builtintypes/* | Adds library test for numeric type classification |
| rust/ql/src/change-notes/2025-10-31-barriers.md | Documents the query improvements |
| /.expected | Updates test expectations to reflect removed false positives |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hvitved
reviewed
Nov 3, 2025
Co-authored-by: Tom Hvitved <hvitved@github.com>
|
Changes accepted, DCA run started... |
|
DCA LGTM. Ready to merge. |
hvitved
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add numeric type barriers for three queries, increasing accuracy. Refines the classes in
Builtins.qllsomewhat to support this.