Overlay: Mark RefType.getAStrictAncestor overlay[caller?]
#19968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginsbach
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks
RefType.getAStrictAncestoroverlay[caller?]to ensure that queries that rely on magic to boundgetAStrictAncestorcan still execute efficiently with overlay compilation enabled.Queries that rely on magic to ensure efficient bounding of
getAStrictAncestorincludesjava/useless-type-test,java/useless-upcast,java/missing-super-finalize,java/non-final-call-in-constructor,java/incorrect-serial-version-uid,java/non-serializable-field,java/unreachable-catch-clause,java/non-static-nested-class,java/lock-order-inconsistency,java/magic-string,java/confusing-override-name. Without magic bounds, these queries regress significantly for thepalatable__lambdaDCA test case.The regressions can also be fixed on the query side by adding suitable
overlay[local?]annotations, but given the number of affected queries, it seems likely that custom queries that usegetAStrictAncestorwould also regress with a solution based on query-side annotations.Overlay compilation is currently disabled for Java and the annotations therefore have no effect on compilation or evaluation at the moment.