Convert remaining {go,swift,ruby}-code-scanning.qls query tests to .qlref
#19817
+1,375
−645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d10c
changed the title
{go,swift,ruby,java}-code-scanning.qls query tests to .qlref
d10c
changed the title
{go,swift,ruby,java}-code-scanning.qls query tests to .qlref{go,swift,ruby}-code-scanning.qls query tests to .qlref
d10c
force-pushed
the
d10c/convert-tests-to-qlref
branch
5 times, most recently
from
4a12777 to
2aaa656
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
d10c
force-pushed
the
d10c/convert-tests-to-qlref
branch
from
2aaa656 to
c628653
Compare
d10c
force-pushed
the
d10c/convert-tests-to-qlref
branch
from
c628653 to
657e782
Compare
geoffw0
previously approved these changes
Jun 23, 2025
| TestRemoteSource() { this.asExpr().(ApplyExpr).getStaticTarget().getName().matches("source%") } | ||
|
|
||
| override string getSourceType() { result = "Test source" } | ||
| } |
There was a problem hiding this comment.
This test source isn't supported in the new approach but ... doesn't appear to make any difference. All the test cases use String(contentsOf: ...) as their sources anyway.
hvitved
requested changes
Jun 24, 2025
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| def foo | |||
| def download_tools(installer) | |||
| Excon.get(installer[:url]) # $ MISSING: BAD= (requires hash flow) | |||
| Excon.get(installer[:url]) # $ MISSING: $Alert (requires hash flow) | |||
There was a problem hiding this comment.
The $ in front of Alert should be removed.
| cmd = params[:cmd] | ||
| `#{cmd}` | ||
| system(cmd) | ||
| cmd = params[:cmd] # $Source |
There was a problem hiding this comment.
Nit: We typically have a space after the $ marker.
There was a problem hiding this comment.
Oh yeah, I missed that when reviewing Go.
d10c
force-pushed
the
d10c/convert-tests-to-qlref
branch
from
657e782 to
35a48e7
Compare
|
Rebased with the suggestions applied (including adding a space in |
hvitved
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the remaining
{go,swift,ruby}-code-scanning.qlsquery tests to.qlref.Example prior work: #18848
In the Go IncorrectIntegerConversion case, the
#select,edges, andnodesquery predicates have different results depending on whether the Go source is compiled under 64-bit or 32-bit mode. So I have filtered out those predicates using a custom test post-processor.Also, in the Ruby case I've made the
utils/test/PrettyPrintModels.qltest postprocessor available; Swift apparently doesn't support the Models-as-Data extensible predicates, so I couldn't fit its existing MaD support into thecodeql.dataflow.test.ProvenancePathGraph::TestPostProcessing::TranslateProvenanceResults<>interface.Anecdotally, the Copilot "Next Edit Suggestion" feature had some marginal benefit for this PR.