Rust: SSA: restrict mutablyBorrowed to variables with a 'mut' modifier #19024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- rust/ql/lib/codeql/rust/dataflow/internal/SsaImpl.qll: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Contributor
|
This makes sense. Note that I think predicate isMutable() { this.getPat().isMut() or this.getSelfParam().isMut() }(just a heads up, could be done in follow up work) |
aibaars
force-pushed
the
aibaars/mut-borrow
branch
from
f109de9 to
80bdd81
Compare
aibaars
force-pushed
the
aibaars/mut-borrow
branch
from
80bdd81 to
1e94245
Compare
paldepind
approved these changes
Mar 14, 2025
Contributor
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
Looks great! 🎉 Thanks for fixing this.
hvitved
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.